Add base User authentication #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresag4
force-pushed
the
user-authentication
branch
3 times, most recently
from
5ae5a6d to
18ae7af
Compare
Closed
Sergio-e
reviewed
Jul 6, 2024
There was a problem hiding this comment.
In general, I think it looks good. I think adding system specs would be a good idea before merging to main. The main areas of focus should be sessions and registrations but if time allows adding specs to reset passwords would be helpful. Take a look at the README on how to write system specs and I'll be glad to help if you need any assistance.
andresag4
force-pushed
the
user-authentication
branch
6 times, most recently
from
ea267d7 to
fdcbff7
Compare
LuigiR0jas
reviewed
Jul 10, 2024
andresag4
force-pushed
the
user-authentication
branch
from
fdcbff7 to
0f18d95
Compare
LuigiR0jas
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.