Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVO Basic setup #53

Merged
merged 4 commits into from
Jul 24, 2024
Merged

AVO Basic setup #53

merged 4 commits into from
Jul 24, 2024

Conversation

andresag4
Copy link
Collaborator

@andresag4 andresag4 commented Jul 18, 2024 •
edited
Loading

Description

Login as admin user and navigate to /avo

How has this been tested?

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Add any tasks that need to be done before/after the release of this feature.

Screenshots/Loom

image image image image

@andresag4 andresag4 changed the title Setup AVO Setup AVO | WIP Jul 18, 2024
@andresag4 andresag4 marked this pull request as draft July 18, 2024 23:47
@andresag4 andresag4 marked this pull request as ready for review July 21, 2024 20:52
@andresag4 andresag4 force-pushed the 43-basic-admin-panel-setup branch 2 times, most recently from eb35906 to dbe39e2 Compare July 22, 2024 18:44
@LuigiR0jas LuigiR0jas changed the title Setup AVO | WIP AVO Basic setup Jul 22, 2024
@LuigiR0jas LuigiR0jas requested a review from Sergio-e July 22, 2024 22:16
Sergio-e
Sergio-e reviewed Jul 23, 2024
View reviewed changes
app/models/user.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
config/initializers/avo.rb Show resolved Hide resolved
config/initializers/avo.rb Outdated Show resolved Hide resolved
app/controllers/concerns/authentication.rb Outdated Show resolved Hide resolved
app/controllers/avo/base_resources_controller.rb Outdated Show resolved Hide resolved
config/initializers/avo.rb
end

config.authenticate_with do
user = User.find_by(id: session[:user_id])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can stay with this approach, that is, there is no need to create an AdminUser model and a separate authentication logic

@Sergio-e
Copy link
Collaborator

Let's also improve the seeds by creating a user with an admin role

@andresag4 andresag4 requested a review from Sergio-e July 23, 2024 22:57
@Sergio-e Sergio-e enabled auto-merge July 24, 2024 15:09
@Sergio-e Sergio-e merged commit 4be8a39 into main Jul 24, 2024
4 checks passed
@Sergio-e Sergio-e deleted the 43-basic-admin-panel-setup branch July 24, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergio-e Sergio-e Sergio-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresag4 @Sergio-e