Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigation #52

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Add navigation #52

merged 12 commits into from
Jul 30, 2024

Conversation

EdgarB
Copy link
Contributor

@EdgarB EdgarB commented Jul 18, 2024

Description

Add navigation bar.

How has this been tested?

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Add any tasks that need to be done before/after the release of this feature.

Screenshots/Loom

This section is relevant in case we want to share progress with the team, otherwise, it can be omitted.

@EdgarB EdgarB marked this pull request as ready for review July 18, 2024 16:41
@LuigiR0jas LuigiR0jas self-requested a review July 22, 2024 20:49
Base automatically changed from feature/new-profile to main July 25, 2024 22:34
Copy link
Collaborator

@LuigiR0jas LuigiR0jas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Another thing I noticed is that the navbar should stay always at the bottom even if there's no content pushing it down.

app/views/layouts/_bottom_navbar.html.erb Outdated Show resolved Hide resolved
app/helpers/navigation_helper.rb Outdated Show resolved Hide resolved
app/views/layouts/application.html.erb Outdated Show resolved Hide resolved
app/views/profiles/show.html.erb Outdated Show resolved Hide resolved
app/assets/images/avatar_no_fill.svg Outdated Show resolved Hide resolved
@EdgarB EdgarB requested a review from LuigiR0jas July 26, 2024 22:20
@LuigiR0jas LuigiR0jas merged commit c8d0b10 into main Jul 30, 2024
4 checks passed
@LuigiR0jas LuigiR0jas deleted the feature/navigation branch July 30, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants