Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the following correlated PR for an issue description and details:
Telmate/proxmox-api-go#238
Currently, every
ipconfigX
config property is set to an empty string no matter what. This is due to the use of.Get()
:The problem is this will always return an empty string. That mixed with the
.(string)
cast makes for a bug.The map value for each
ipconfig
entry should not be set unless it actually is set in the config. This PR uses.GetOk()
instead, and only sets the map value when there actually is one.