Overhaul Cloud-Init ipconfig v2 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sebastian-de this should be good! I would only add a check to not exceed 16 ipconfig elements, or at least that we cannot have ipconfig16 and upper, this would give an api error for sure |
|
Hey @mleone87 thanks for the review! I'm away for the rest of the week - I'll add the required change next Monday/Tuesday.
|
sebastian-de
commented
Nov 14, 2022
|
@mleone87 gentle ping - I added the check, is there anything else that needs to be done to get this merged? |
so sorry that I completely miss the commit! |
Tinyblargon
added a commit
to Tinyblargon/terraform-provider-proxmox
that referenced
this pull request
Jan 12, 2023
Telmate/proxmox-api-go#216 change the types of the cloud-init config.
mleone87
pushed a commit
to Telmate/terraform-provider-proxmox
that referenced
this pull request
Jan 12, 2023
Telmate/proxmox-api-go#216 change the types of the cloud-init config.
frostyfab
pushed a commit
to frostyfab/proxmox-api-go
that referenced
this pull request
Nov 17, 2023
Overhaul Cloud-Init ipconfig v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in issue #214
Supersedes #215