Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul: Qemu Network interfaces. #341

Closed
Tinyblargon opened this issue Jun 13, 2024 · 2 comments · Fixed by #365
Closed

Overhaul: Qemu Network interfaces. #341

Tinyblargon opened this issue Jun 13, 2024 · 2 comments · Fixed by #365
Assignees
Labels
type/enhancement An improvement of existing functionality

Comments

@Tinyblargon
Copy link
Collaborator

The network adapters of ConfigQemu{} don't neatly map to the data-structure the PVE API uses.
We currently use an array.
PVE uses an map[id]settings.

With our current implementation it's not possible to have network interfaces that aren't consecutive.
In PVE users can have interface1 and interface3 configured. Our current implantation can't distinguish between.

  • inteface1
  • interface2

and

  • interface1
  • interface5

In this instance interface5 is the second interface. so it will be the second item in the array.
Before you start working on this please discuss it with me.

@Tinyblargon
Copy link
Collaborator Author

This will include #333

@Tinyblargon Tinyblargon self-assigned this Aug 27, 2024
@Tinyblargon
Copy link
Collaborator Author

Tinyblargon added a commit that referenced this issue Oct 28, 2024
 Overhaul: Qemu Network interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant