Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ErrorFeedback): new component #883

Closed
wants to merge 2 commits into from
Closed

Conversation

@github-actions
Copy link

Size stats

master this branch diff
Total JS 9.47 MB 9.47 MB +1.16 kB
JS without icons 963 kB 964 kB +1.12 kB
Lib overhead 125 kB 125 kB 0 B
Lib overhead (gzip) 32.2 kB 32.2 kB 0 B

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-81lb07gwx-tuentisre.vercel.app

Built with commit 5f092fd.
This pull request is being automatically deployed with vercel-action

export const ErrorFeedback: React.FC<ErrorFeedbackScreenProps> = ({
title,
description,
primaryButton,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the icon would need to be parametrizable if we are to keep the current VIVO "customization":

platform.getAppBrand() === 'VivoBR' ? (
                    <IconWarningLight color={skinVars.colors.error} size={60} />
                ) : (
                    <IconFileErrorLight color={skinVars.colors.brand} size={60} />
                )

Copy link
Contributor Author

@atabel atabel Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... I don't think so. ErrorFeedbackScreen doesn't allow you to configure the error icon, I don't se why ErrorFeedback should allow it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could expose some kind of generic customizable Feedback as we do with FeedbackScreen if it's really needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the aim is to solve the current issue I raised, yes, we would need that Feedback

if you look at web/src/common/components/full-page-error in webapp, we are using FeedbackScreen instead of ErrorFeedbackScreen because of the fact that the icon needs to be configurable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It makes sense, but I'm a bit worried we could be over abusing this configurability, we should try to follow the standard ErrorFeedback/ErrorFeedbackScreen design whenever possible unless there is a strong reason. That's the main point of having a Design System. @aweell, what's Design Core opinion on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're worried too we're not following the definition correctly, if we're going to display an error the icon should be consistent. So using errorFeedback / errorFeedbackScreen should be the way to go.

I'm digging into this need with product design. @Winde if you have examples of these cases at hand and can share them, it would be very valuable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a storybook where it can be seen the icon changing per brand: https://storybook.tuenti.io/?path=/story/account-common-components-fullpageerror--default

Here's the tickets of the last update of this component in webapp:
https://jira.tid.es/browse/PRODUCTDSN-1246
https://jira.tid.es/browse/ACCOUNT-21143

I'm asking @montse for more info on why it was determined a different icon for VIVO.

@Winde Winde self-requested a review September 14, 2023 08:22
@marcoskolodny marcoskolodny deleted the atoledano-error-feedback branch May 31, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants