Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): remove extra margin in safari #857

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

marcoskolodny
Copy link
Collaborator

In Safari, buttons have extra padding/margin by default (stack overflow post). We need to remove this for tabs.

Issue: Link

@github-actions
Copy link

Size stats

master this branch diff
Total JS 9.42 MB 9.42 MB 0 B
JS without icons 915 kB 915 kB 0 B
Lib overhead 127 kB 127 kB 0 B
Lib overhead (gzip) 32.9 kB 32.9 kB 0 B

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-johs1fhqs-tuentisre.vercel.app

Built with commit 4fc5507.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@marcoskolodny marcoskolodny changed the title fix tab extra margin in safari fix(Tabs): remove extra margin in safari Aug 21, 2023
src/tabs.css.ts Outdated Show resolved Hide resolved
src/tabs.css.ts Show resolved Hide resolved
@atabel atabel added this pull request to the merge queue Aug 24, 2023
Merged via the queue into master with commit be8c2f2 Aug 24, 2023
10 checks passed
@atabel atabel deleted the WEB-1510-fix-tabs-border branch August 24, 2023 09:22
tuentisre pushed a commit that referenced this pull request Aug 24, 2023
# [14.21.0](v14.20.1...v14.21.0) (2023-08-24)

### Bug Fixes

* **Cards:** remove min width from all the cards ([#858](#858)) ([029a6ea](029a6ea))
* **Tabs:** remove extra margin in safari ([#857](#857)) ([be8c2f2](be8c2f2))

### Features

* **FeedbackScreens:** updates in icons, paddings and styling ([#852](#852)) ([4b231e6](4b231e6))
* **Sheet:** new component ([#840](#840)) ([f03ca7c](f03ca7c))
* **utilities:** Remove lodash dependency and replace it with custom functions ([#856](#856)) ([dcaf691](dcaf691))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants