feat(Rows, Cards, FeedbackScreen, FormFields, Buttons): add test ids for components and their internal elements #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 7eb976c. |
|
Screenshot tests report ✔️ All passing |
marcoskolodny
commented
Oct 18, 2024
| @@ -90,6 +90,7 @@ export const InternalBoxed = React.forwardRef<HTMLDivElement, Props & InternalPr | |||
| ref | |||
| ) => { | |||
| const isInverseOutside = useIsInverseOrMediaVariant(); | |||
| const isInverseInside = isInverse || variant === 'inverse' || variant === 'media'; | |||
There was a problem hiding this comment.
Unrelated, but Boxed was not working properly when using media variant
marcoskolodny
commented
Oct 18, 2024
| ref={ref} | ||
| className={styles.touchableContainer} | ||
| aspectRatio={aspectRatio} | ||
| aria-label={isTouchable ? undefined : ariaLabelProp} | ||
| > | ||
| <Boxed className={styles.boxed} isInverse={isInverse} width="100%" minHeight="100%"> |
There was a problem hiding this comment.
unrelated, but I saw this usages of deprecated isInverse prop and updated them in order to use variant instead
marcoskolodny
commented
Oct 18, 2024
| @@ -74,7 +74,7 @@ export const Default: StoryComponent<Args> = ({forceNonCssAspectRatio}) => { | |||
| ); | |||
|
|
|||
| return ( | |||
| <Stack space={16} dataAttributes={{testId: 'story'}}> | |||
There was a problem hiding this comment.
unrelated, but camelCase is not correct here
atabel
approved these changes
Oct 21, 2024
pladaria
approved these changes
Oct 21, 2024
pladaria
approved these changes
Oct 21, 2024
tuentisre
pushed a commit
that referenced
this pull request
Nov 4, 2024
# [16.4.0](v16.3.1...v16.4.0) (2024-11-04) ### Bug Fixes * **TextField:** adjust position of maxLength's screen reader label ([#1283](#1283)) ([fda424e](fda424e)) * **TextField:** avoid right helper text from wrapping, fix spacing and aria label for maxCount text when multiline is true ([#1272](#1272)) ([85fcb31](85fcb31)) * **useDisableBodyScroll:** avoid affecting body's height ([#1279](#1279)) ([b68f317](b68f317)) ### Features * **PhoneNumberFieldLite:** Phone number field with simple formatting to reduce bundle size ([#1276](#1276)) ([a141b97](a141b97)) * **Row:** allow aria-label in informative rows ([#1269](#1269)) ([65b5d42](65b5d42)) * **Rows, Cards, FeedbackScreen, FormFields, Buttons:** add test ids for components and their internal elements ([#1270](#1270)) ([fc63201](fc63201)) * **Spinner:** improve a11y ([#1274](#1274)) ([5267ad5](5267ad5)) * **Switch, RadioButton, Checkbox, ProgressBar, ProgressBarStepped, Slider:** create inverse variant ([#1277](#1277)) ([3129fb9](3129fb9))
|
🎉 This PR is included in version 16.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link