-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CoverHero): new component #1144
Merged
+1,202
−112
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a8a2a35
WEB-1848 feat(CoverHero): new component
atabel b5a9e8d
Merge branch 'master' into atoledano-cover-hero
atabel 6d9461c
cover hero
atabel ef3a01b
Merge branch 'master' into atoledano-cover-hero
atabel fe2d62c
fix dark mode
atabel 48dd2ed
update screenshots
atabel 6ab715f
removed image zindex
atabel f06b9aa
story inside slideshow. Snippets
atabel 7050a1d
aria-label dataAttributes and background instead of backgroundColor
atabel 1333362
fixes from CR
atabel 65a68fc
fix description width when using centered+sideExtra
atabel 07aa5e7
take screenshots of the component instead of the whole page
atabel 07892d8
Merge branch 'master' into atoledano-cover-hero
atabel 280a690
allow CoverHero without buttons
atabel 6fc25a0
ssr test
atabel 516baf5
limit centered content to 8 columns
atabel 68cca1f
Merge branch 'master' into atoledano-cover-hero
atabel 5307fa6
aspect-ratio polyfill
atabel e8fad1f
add component-name to GridLayout
atabel 904e361
Merge branch 'master' into atoledano-cover-hero
atabel c591980
improve story comment
atabel d465585
add reference to csf PR
atabel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
add component-name to GridLayout
commit e8fad1fe8770ff488318eb6c8a92f3141d1b2597
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prop is new, this will allow configuring
GridLayout
to collapse in mobile breackpoint instead of tablet (default behaviour). This mode is required inCoverHero