Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floppy-disk for o2 style #1956

Closed
2 tasks done
iveneva1 opened this issue Nov 13, 2024 · 4 comments
Closed
2 tasks done

floppy-disk for o2 style #1956

iveneva1 opened this issue Nov 13, 2024 · 4 comments
Assignees
Labels
brand: o2 fundamentals: icons new request ✨ Add a new component to design system or evolve an existing one
Milestone

Comments

@iveneva1
Copy link

Contribution guidelines

What brand do you need to include these icons?

O2

Is your icon request related to a need?

We need an icon to symbolyze saving action. The save icon exists in the most standard icon sets and is beeing used for saving actions in different application.

Describe or attach a screenshot of the solution you'd like and needs

Save Icon.

icons_save.zip

Describe icon alternatives you've considered

We didn't find any similar alternative for the save action

Additional context?

The icon should be used in the o2 for You App, where the user can actively save an action - for example the user fills out a form and wants to save the changes.

Attach your svg icon with 3 weights (light / regular / filled)

save_light
save_regular
save_filled

@iveneva1 iveneva1 added fundamentals: icons request ✨ Add a new component to design system or evolve an existing one labels Nov 13, 2024
@yceballost yceballost added this to the 15.3.0 milestone Nov 14, 2024
@yceballost
Copy link
Collaborator

thanks for your contribution 🥰 we will include it for the next release https://github.com/Telefonica/mistica-design/milestone/65

@yceballost yceballost self-assigned this Nov 14, 2024
@yceballost yceballost changed the title Save-Icon for o2 style floppy-disk for o2 style Nov 18, 2024
@yceballost
Copy link
Collaborator

yceballost commented Nov 18, 2024

We changed the name from save to floppy-disk to make the name more objective

@iveneva1
Copy link
Author

@yceballost , thank you a lot for the quick implementation. Our developers are asking me something, I hope you can help us. They are telling me, that they can see the icon in the design library, but they are telling me, that they can not use the icon, because it wasn't deployed in any web-releases yet. Could that be and do you know when it is going to be released?

@yceballost
Copy link
Collaborator

We usually wait for more new icons before to generate a new PR in code repository to avoid too much reviews for each new icon include but, no problem, I will create a PR in web repo to include it in code side :)
Telefonica/mistica-web#1304

github-merge-queue bot pushed a commit to Telefonica/mistica-web that referenced this issue Dec 13, 2024
We force this update because there is a team that need the icon

Telefonica/mistica-design#1956 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand: o2 fundamentals: icons new request ✨ Add a new component to design system or evolve an existing one
Projects
Status: Backlog
Development

No branches or pull requests

2 participants