-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @swc/core to v1.3.84 #440
Conversation
Branch automerge failureThis PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
|
9f61bee
to
4c4dd7c
Compare
@sgoodluck: guessing you know the most about the swc stuff and the experimental import assertions. The initial issue here is that swc renamed from I took a quick look through our code and the only apparent use of import assertions is in the one test file here. I removed the assertion usage... and it all still worked, so I think this is fine? |
Hmm, I know @nikkhn and I battled this a fair bit before. It's possible with the major updates in Node that this is no longer required. I'm inclined to accept the PR and try to deploy it to develop to see what happens. Running locally may conflict with how it behaves when building and deploying to CFP. A brief bit of googling shows some chatter on the topic. Another related thread around ts-node. Let's find out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve with the caveat that we may need to roll it back!
Actually, looks like they've released 1.3.84 which includes a fix for this. I'm going to close this branch and have renovate open a new one with the updated version. Can fix the config and then hopefully we'll be good to go! |
35dd015
to
7af4081
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
@nikkhn i ended up having renovate upgrade this PR rather than closing and opening a new one, so this is actually still good! |
OH ok :D |
This PR contains the following updates:
1.3.80
->1.3.84
Release Notes
swc-project/swc (@swc/core)
v1.3.84
Compare Source
Bug Fixes
(es/codegen) Emit leading comments for
ExprStmt
(#7916) (2da5895)(es/codegen) Use
emitAssertForImportAttributes
(#7936) (dac8888)(es/compat) Visit assign expr in generator (#7932) (97068e1)
v1.3.83
Compare Source
Bug Fixes
(css/modules) Aggregate class names when composes is chained. (#7917) (0db25a2)
(es/module) Revert #7901 (#7906) (85d6e9b)
(es/module) Fix
jsc.paths
for projects using pnpm (#7918) (a86e9f3)Features
assert
for import attributes (#7914) (ee75756)v1.3.82
Compare Source
Bug Fixes
(common) Fix logic for excluding
FileName
from source maps (#7900) (aa64955)(es/module) Make
jsc.paths
fully resolve TypeScript files (#7901) (c714dd2)(es/resolver) Correctly resolve global value (#7893) (2db10e9)
v1.3.81
Compare Source
Bug Fixes
(es/codegen) Fix placing of comments of yield arguments (#7858) (122d14c)
(es/compat) Apply transforms for explicit resource management (#7881) (3180e68)
(es/compat) Make
SwitchCase
handler ofblock-scoping
stateless (#7888) (4b33d41)(es/dep-graph) Analyze import type children (#7883) (057bd5f)
(es/minifier) Report
is_fn_local
even if var is hoisted (#7876) (87a47bf)(es/module) Don't create absolute paths for
jsc.paths
on Windows (#7892) (5fbc251)(swc-info) Use correct path while getting local package versions (#7872) (67afaf1)
Features
(es) Add an option to disable builtin transforms (#7873) (71d01ec)
(es/ast) Support import attributes proposal (#7868) (4d3fcb8)
(es/preset-env) Update data (#7882) (a97d8b4)
(swc-info) Add a CLI to help issue reporting (#7871) (d6952ea)
Miscellaneous Tasks
memchr
(#7891) (01cbd6e)- general: Usetextarea
forswc-info
(eed2903)Performance
Refactor
mutated
andmutation_by_call_count
(#7890) (8db968a)Configuration
📅 Schedule: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.