Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @swc/core to v1.3.84 #440

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Update dependency @swc/core to v1.3.84 #440

merged 3 commits into from
Sep 12, 2023

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Sep 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@swc/core (source) 1.3.80 -> 1.3.84 age adoption passing confidence

Release Notes

swc-project/swc (@​swc/core)

v1.3.84

Compare Source

Bug Fixes

v1.3.83

Compare Source

Bug Fixes
Features
  • (es/codegen) Add an option to print assert for import attributes (#​7914) (ee75756)

v1.3.82

Compare Source

Bug Fixes
  • (common) Fix logic for excluding FileName from source maps (#​7900) (aa64955)

  • (es/module) Make jsc.paths fully resolve TypeScript files (#​7901) (c714dd2)

  • (es/resolver) Correctly resolve global value (#​7893) (2db10e9)

v1.3.81

Compare Source

Bug Fixes
  • (es/codegen) Fix placing of comments of yield arguments (#​7858) (122d14c)

  • (es/compat) Apply transforms for explicit resource management (#​7881) (3180e68)

  • (es/compat) Make SwitchCase handler of block-scoping stateless (#​7888) (4b33d41)

  • (es/dep-graph) Analyze import type children (#​7883) (057bd5f)

  • (es/minifier) Report is_fn_local even if var is hoisted (#​7876) (87a47bf)

  • (es/module) Don't create absolute paths for jsc.paths on Windows (#​7892) (5fbc251)

  • (swc-info) Use correct path while getting local package versions (#​7872) (67afaf1)

Features
Miscellaneous Tasks
Performance
Refactor
  • (es/minifier) Remove mutated and mutation_by_call_count (#​7890) (8db968a)

Configuration

📅 Schedule: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner September 8, 2023 04:31
@renovate
Copy link
Author

renovate bot commented Sep 8, 2023

Branch automerge failure

This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.


  • Branch has one or more failed status checks

@renovate renovate bot requested review from tshaneh and removed request for a team September 8, 2023 04:31
@renovate renovate bot force-pushed the renovate/swc-monorepo branch from 9f61bee to 4c4dd7c Compare September 8, 2023 04:31
@cwegrzyn cwegrzyn requested a review from sgoodluck September 8, 2023 15:59
@cwegrzyn
Copy link
Contributor

cwegrzyn commented Sep 8, 2023

@sgoodluck: guessing you know the most about the swc stuff and the experimental import assertions. The initial issue here is that swc renamed from keepImportAssertions to keepImportAttributes following a recent change in the ecmascript proposal. That revised proposal changes the keyword from assert to with, because you know, why not. Node/v8 doesn't support this yet, so swc also added a keyword emitAssertForImportAttributes that emits assert instead of with. However, naturally, that is broken.

I took a quick look through our code and the only apparent use of import assertions is in the one test file here. I removed the assertion usage... and it all still worked, so I think this is fine?

@sgoodluck
Copy link
Contributor

Hmm, I know @nikkhn and I battled this a fair bit before. It's possible with the major updates in Node that this is no longer required. I'm inclined to accept the PR and try to deploy it to develop to see what happens. Running locally may conflict with how it behaves when building and deploying to CFP. A brief bit of googling shows some chatter on the topic.

Another related thread around ts-node.

Let's find out!

Copy link
Contributor

@sgoodluck sgoodluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve with the caveat that we may need to roll it back!

@cwegrzyn
Copy link
Contributor

Actually, looks like they've released 1.3.84 which includes a fix for this. I'm going to close this branch and have renovate open a new one with the updated version. Can fix the config and then hopefully we'll be good to go!

@renovate renovate bot changed the title Update dependency @swc/core to v1.3.83 Update dependency @swc/core to v1.3.84 Sep 11, 2023
@renovate renovate bot force-pushed the renovate/swc-monorepo branch from 35dd015 to 7af4081 Compare September 11, 2023 17:17
@renovate
Copy link
Author

renovate bot commented Sep 11, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@nikkhn nikkhn closed this Sep 12, 2023
@cwegrzyn cwegrzyn reopened this Sep 12, 2023
@cwegrzyn
Copy link
Contributor

@nikkhn i ended up having renovate upgrade this PR rather than closing and opening a new one, so this is actually still good!

@nikkhn
Copy link
Contributor

nikkhn commented Sep 12, 2023

@nikkhn i ended up having renovate upgrade this PR rather than closing and opening a new one, so this is actually still good!

OH ok :D

@nikkhn nikkhn merged commit 29f6501 into main Sep 12, 2023
@nikkhn nikkhn deleted the renovate/swc-monorepo branch September 12, 2023 14:15
@nikkhn nikkhn mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants