[IMP] Add some more default configurations #62

lasley · 2017-07-28T18:50:50Z

Add some more configurations, use the defaults from https://github.com/odoo/odoo/blob/3ace806d399e9e3abc5ada84ba98d2de100388d3/odoo/tools/config.py#L277

This is dependent on:

[IMP] Move config generation to entrypoint #60

yajo

You have conflicts.

Please @pedrobaeza review this. Do you think it's worth it, or is it better to have those predefined flavors we talked once?

pedrobaeza · 2017-07-31T09:12:45Z

We should have both: the possibility to define these environment variables (not for us, but for @lasley that needs them), and default sane values.

Please rebase this PR and add these defaults.

yajo · 2017-07-31T09:31:17Z

Dockerfile

+ONBUILD ARG ODOO_LIMIT_TIME_REAL_CRON=1
+ONBUILD ARG ODOO_DB_FILTER=
+ONBUILD ARG ODOO_LIST_DB=1
+ONBUILD ARG ODOO_LOG_LEVEL=info


@pedrobaeza You can see the defaults he's adding here.

The problem is that for performance there are no sane defaults for everyone. If you apply a 32 core's sane defaults to a 4 core machine, it would get exhausted.

My original idea was to have some sane disabled defaults in config files that you could symlink in your custom/conf.d directory.

Imagine something like /opt/odoo/common/disabled-conf.d/ with files like:

1vcpu.conf

2vcpu.conf

4vcpu.conf

8vcpu.conf (etc.)

4gbram.conf

8gbram.conf

32gbram.conf (etc.)

Similar to apache's sites-available vs sites-enabled.

So you can add those with ln -s /opt/odoo/common/disabled-conf.d/{8vcpu,32gbram}.conf custom/conf.d and have a community-maintained sane default for your machine. Or we could use an env var for that if it seems more convenient.

IMO because the variety of uses for this image, we shouldn't make too many assumptions about the deploy by default.

Basically all I did here was expose some more configuration options, using specifically the ones Odoo sets as default.

I think the better configuration would just be a part of the env files in scaffolds though:

odoo: env_file: - common.env - 4vcpu.env - 32gbram.env

Note the above obviously wouldn't work if the configuration is being generated during build, but this also highlights why it should be in the endpoint instead. It seems pretty weird to statically define infrastructure capacity in a Docker image IMO

yajo · 2017-07-31T09:31:29Z

Dockerfile

+ONBUILD ARG ODOO_LIMIT_MEMORY_HARD=805306368
+ONBUILD ARG ODOO_LIMIT_MEMORY_SOFT=671088640
+ONBUILD ARG ODOO_LIMIT_REQUEST=8192
+ONBUILD ARG ODOO_LIMIT_TIME_REAL_CRON=1


1 second for crons? not much sane...

Oops this was -1 in the defaults. Guess I can't read!

Still missing...

yajo · 2017-07-31T09:31:49Z

Dockerfile

@@ -27,10 +28,38 @@ ONBUILD ARG PGUSER=odoo
 ONBUILD ARG PGPASSWORD=odoopassword
 ONBUILD ARG PGHOST=db
 ONBUILD ARG PGDATABASE=prod
-ONBUILD ENV PGUSER="$PGUSER" \
+ONBUILD ARG ODOO_MAX_CRON_THREADS=1
+ONBUILD ARG ODOO_WORKERS=0


Minimum 2 workers are required for production. Defaults should go for production always.

I explicitly aligned with the defaults of Odoo so as to not change the operation of anything from default. I feel that this is better than attempting to make some determination of what someone wants for this image.

lasley · 2017-08-02T16:10:11Z

Hmmm so the build is failing, but I don't see how this is something I could have caused with this change & I have absolutely no idea how to fix it. Ideas?

run-parts: failed to exec /opt/odoo/common/build.d/999-dependencies-cleanup: Text file busy
run-parts: /opt/odoo/common/build.d/999-dependencies-cleanup exited with return code 1

lasley · 2017-08-02T16:10:58Z

(note I rebuilt three or four times under the hope it was a random error that would pass. no luck)

yajo · 2017-08-04T08:12:05Z

Please rebase

lasley · 2017-08-04T17:42:49Z

Rebase looks to have cleared it

yajo

Hi there @lasley, thanks!

I'm suggesting some little changes on the defaults. They diverge from Odoo's, but seem more sensible under our experience. Maybe @pedrobaeza wants to add some further suggestions before merging?

The thing I'm not sure about with this PR is what happens for preexisting projects that have their custom/conf.d configurations? Next builds might get 2 values for the same key, and which one would take preference? Or would there be an error? Could you add a test for that please?

Also, does this have any value above changing the CMD that boots each container, adding the settings in CLI?

yajo · 2017-08-07T07:18:51Z

Dockerfile

+ONBUILD ARG ODOO_LIMIT_MEMORY_HARD=805306368
+ONBUILD ARG ODOO_LIMIT_MEMORY_SOFT=671088640
+ONBUILD ARG ODOO_LIMIT_REQUEST=8192
+ONBUILD ARG ODOO_LIMIT_TIME_REAL_CRON=1


Still missing...

yajo · 2017-08-07T07:20:17Z

Dockerfile

@@ -28,6 +28,17 @@ ONBUILD ARG PGUSER=odoo
 ONBUILD ARG PGPASSWORD=odoopassword
 ONBUILD ARG PGHOST=db
 ONBUILD ARG PGDATABASE=prod
+ONBUILD ARG ODOO_MAX_CRON_THREADS=-1


Default to 1.

yajo · 2017-08-07T07:21:07Z

Dockerfile

@@ -28,6 +28,17 @@ ONBUILD ARG PGUSER=odoo
 ONBUILD ARG PGPASSWORD=odoopassword
 ONBUILD ARG PGHOST=db
 ONBUILD ARG PGDATABASE=prod
+ONBUILD ARG ODOO_MAX_CRON_THREADS=-1
+ONBUILD ARG ODOO_WORKERS=0


Default to 2 (minimal required workers to get a functional worker-enabled odoo)

yajo · 2017-08-07T07:25:15Z

Dockerfile

+ONBUILD ARG ODOO_MAX_CRON_THREADS=-1
+ONBUILD ARG ODOO_WORKERS=0
+ONBUILD ARG ODOO_LIMIT_TIME_REAL=120
+ONBUILD ARG ODOO_LIMIT_TIME_CPU=60


In our experience it's quite better to increase these 2 defaults. Simple standard operations such as downloading a db backup never get done with these values. At least 10x please.

yajo · 2017-08-07T07:28:31Z

conf.d/60-performance.conf

+limit_memory_hard=$ODOO_LIMIT_MEMORY_HARD
+limit_memory_soft=$ODOO_LIMIT_MEMORY_SOFT
+limit_request=$ODOO_LIMIT_REQUEST
+limit_time_real_cron=$ODOO_LIMIT_TIME_REAL_CRON


Please surround = signs with spaces like in the other config files.

yajo · 2017-08-07T07:28:35Z

conf.d/70-security.conf

@@ -0,0 +1,3 @@
+[options]
+dbfilter=$ODOO_DB_FILTER
+list_db=$ODOO_LIST_DB


spaces here too.

BTW, if you are naming this file "security", please move admin_passwd here, to be consistent, please.

yajo · 2017-08-07T07:28:41Z

conf.d/80-logging.conf

@@ -0,0 +1,2 @@
+[options]
+log_level=$ODOO_LOG_LEVEL


lasley · 2017-08-07T16:13:28Z

I'm suggesting some little changes on the defaults. They diverge from Odoo's, but seem more sensible under our experience. Maybe @pedrobaeza wants to add some further suggestions before merging?

I really don't like changing the Odoo defaults. Why should we make the users memorize a completely new set of defaults? I agree that the Odoo ones aren't sensible in some scenarios, but that is what they are & they don't actually hurt anything.

IMO the scaffolds are where we should be making configuration decisions. We just need a way to expose them to the user so that they're not remaking all of these scripts.

Furthermore, I don't agree with the recommended default change to increase the worker time 10x. Our deploys use isolated cron and service instances that allow for long running operations. Web facing instances should not allow this type of thing, which can be an avenue for DOS. This is another reason that I think we should just leave the defaults - all of these options are contextual & everyone will have different ones.

lasley · 2017-08-07T16:27:04Z

Regarding the duplications in configs - the last configuration item defined takes precedence.

Which order do the configs drop in? Common then custom? or is it Custom then Common like it was in build/entry?

yajo · 2017-08-08T07:19:08Z

Regarding the duplications in configs - the last configuration item defined takes precedence.

Can we have a test on that please? You can test it with a simple odoo shell script.

Which order do the configs drop in?

It's common and then custom.

lasley · 2017-08-08T16:23:06Z

Ok so I think that this works out great then with the custom coming after common, it can be completely controlled externally.

Will add test, although I'm not quite sure what you mean by a shell script? I'll submit what I'm thinking, but I don't think it aligns with what you are because there's no script.

yajo · 2017-08-09T07:23:12Z

tests/scaffoldings/dotd/docker-compose.yaml

    depends_on:
-      - postgresql
+      - postgresql:manual_db_host


BTW This is not a valid syntax, although you have to revert this anyway (see above)

yajo · 2017-08-09T07:35:35Z

tests/scaffoldings/dotd/docker-compose.yaml

@@ -10,9 +10,8 @@ services:
    environment:
      PGUSER: another_odoo
      PGPASSWORD: anotherodoopassword
-      PGHOST: postgresql


I think some entrypoint script will fail if you set an invalid $PGHOST anyway.

I think I will explain better the test I expected:

Add to environment:

ODOO_LIMIT_REQUEST: 8000 ODOO_LIST_DB: 0

Add a dotd/custom/conf.d/request_limit.conf with:

[options] limit_request = 9000

Add dotd/custom/entrypoint.d/600-goodconf.py:

#!/usr/local/bin/python-odoo-shell from odoo.tools import config assert config.get("limit_request") == 9000 assert not config.get("list_db")

This way we make sure the env variables get into config, and that manual configs override them.

lasley · 2017-08-09T18:53:19Z

It seems Travis keeps failing on the below & it seems to be across all my PRs. Any ideas?

WARNING:docker-odoo-base:Blindly symlinking odoo executable
Traceback (most recent call last):
  File "/opt/odoo/common/build", line 26, in <module>
    subprocess.check_call(command)
  File "/usr/lib/python2.7/subprocess.py", line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 26] Text file busy

yajo · 2017-08-10T07:33:49Z

Can you rebase please?

lasley · 2017-08-24T16:26:11Z

Hmmm so do we have any idea what's causing the text file error? Should I just rebase until it passes? It totally seems like something intermittent that is spread across all PRs

yajo · 2017-08-25T06:59:49Z

See #65, which I'll reopen now.

lasley · 2017-11-14T17:38:29Z

Is there anything else I need to do here other than rebase?

yajo

I comment below some missing points.

Also please remember to add changes to all Dockerfiles. We have 11.0 now!

Besides, with the rebase, you should get #65 fixed.

yajo · 2017-11-15T13:14:07Z

conf.d/60-performance.conf

@@ -0,0 +1,9 @@
+[options]


You have to remove this here and in the other files. It fails in Odoo 11

yajo · 2017-11-15T13:16:14Z

Dockerfile

@@ -29,6 +29,17 @@ ONBUILD ARG PGUSER=odoo
 ONBUILD ARG PGPASSWORD=odoopassword
 ONBUILD ARG PGHOST=db
 ONBUILD ARG PGDATABASE=prod
+ONBUILD ARG ODOO_MAX_CRON_THREADS=2
+ONBUILD ARG ODOO_WORKERS=0


Since the image should be production first, I guess we can put 4 here, or at least 2 (minimum required for odoo to work and print reports).

yajo · 2017-11-15T13:18:47Z

Dockerfile

+ONBUILD ARG ODOO_LIMIT_TIME_REAL_CRON=-1
+ONBUILD ARG ODOO_DB_FILTER=""
+ONBUILD ARG ODOO_LIST_DB=1
+ONBUILD ARG ODOO_LOG_LEVEL=info


Do you think we can reuse image's LOG_LEVEL? Or do you prefer to keep them separate?

IMO it would be best to keep them separate. The image log to me is a build/boot thing, vs the Odoo log being runtime. While they may be coordinated, they're for different people to use (the builder vs the maintainer)

pedrobaeza · 2017-12-12T09:32:31Z

Any news with this?

lasley · 2017-12-12T21:38:26Z

Updated. Sorry for the lag

yajo

Travis is ❌
Do we really need to prefix all of these with ODOO_? I think that's implicit...
Some other comments to make this even more awesome out of the box.
Great job! 😊

yajo · 2017-12-13T08:48:07Z

8.0.Dockerfile

@@ -29,6 +29,17 @@ ONBUILD ARG PGUSER=odoo
 ONBUILD ARG PGPASSWORD=odoopassword
 ONBUILD ARG PGHOST=db
 ONBUILD ARG PGDATABASE=prod
+ONBUILD ARG ODOO_MAX_CRON_THREADS=2
+ONBUILD ARG ODOO_WORKERS=2


I think 4 is a better default here. 2 should be the minimal amount of workers to get a prefork server up and running, but even servers with a single CPU should be able to handle 4 workers nowadays, and it seems a better production default. The devel and test environments override this default already:

https://github.com/Tecnativa/docker-odoo-base/blob/447f57c547896b2212f68db8fa5308da7473bd99/devel.yaml#L36

https://github.com/Tecnativa/docker-odoo-base/blob/447f57c547896b2212f68db8fa5308da7473bd99/test.yaml#L34

yajo · 2017-12-13T08:49:34Z

8.0.Dockerfile

@@ -29,6 +29,17 @@ ONBUILD ARG PGUSER=odoo
 ONBUILD ARG PGPASSWORD=odoopassword
 ONBUILD ARG PGHOST=db
 ONBUILD ARG PGDATABASE=prod
+ONBUILD ARG ODOO_MAX_CRON_THREADS=2


I think a better default is 1. 2 crons can collide each other and produce more concurrency errors, and besides cron jobs are usually not that important that can't be delayed a little bit until the previous job finishes. It's better to default to 1 and let customizations increase that number.

yajo · 2017-12-13T08:51:33Z

8.0.Dockerfile

+ONBUILD ARG ODOO_MAX_CRON_THREADS=2
+ONBUILD ARG ODOO_WORKERS=2
+ONBUILD ARG ODOO_LIMIT_TIME_REAL=120
+ONBUILD ARG ODOO_LIMIT_TIME_CPU=60


With these limits it's quite common that you cannot download a database backup. I'd increase both to 5 minutes minimum by default.

IMO it's best to leave these at Odoo default and let a developer decide. I run my productions with these limits for security purposes. There is no reason a database backup should be able to complete from a production instance using user-facing methods

yajo · 2017-12-13T08:52:14Z

tests/scaffoldings/dotd/custom/conf.d/request_limit.conf

@@ -0,0 +1,2 @@
+[options]


Remove this line or it will fail in odoo v11

lasley · 2017-12-13T16:59:23Z

Do we really need to prefix all of these with ODOO_? I think that's implicit...

IIRC there were some collisions, so I thought it best for consistency purposes. There's a lot more than just Odoo variables in this env

yajo

It seems the test fails in odoo 9+ because AFAICS you cannot run a shell script against a database that does not exist.

Maybe you can fix the CI with just a 500-createdb.sh file such as:

#!/usr/bin/env bash
# Need a preexisting DB to run odoo shell scripts
psql -d postgres -c "CREATE DATABASE $PGDATABASE"

lasley · 2017-12-14T17:14:58Z

Done. /crosses_fingers

yajo · 2017-12-15T08:36:05Z

tests/scaffoldings/dotd/custom/entrypoint.d/500-create-db.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+# Need a preexisting DB to run odoo shell scripts
+psql -d postgres -c "CREATE DATABASE $PGDATABASE"


Delete this file. See below.

yajo · 2017-12-15T08:49:02Z

tests/scaffoldings/dotd/custom/entrypoint.d/600-goodconf.py

@@ -0,0 +1,4 @@
+#!/usr/local/bin/python-odoo-shell
+from odoo.tools import config


There's a problem on putting these test files at the entrypoint: both get executed before each test in dotd, and there are a lot.

Put this file in a separate script dotd/custom/extras/goodconf.py. Then add a command to the list that executes this script. Make sure you add the command after another test that should have created a database, this way you don't have to worry about the DB creation thing.

yajo · 2017-12-15T08:52:03Z

tests/scaffoldings/dotd/custom/entrypoint.d/600-goodconf.py

@@ -0,0 +1,4 @@
+#!/usr/local/bin/python-odoo-shell
+from odoo.tools import config
+assert config.get("limit_request") == 9000


I'm afraid we will need some more magic to make this test pass, because on v11 you cannot have duplicate config entries, 😕 possibly a new limitation on Python 3 implementation.

Merging as is would break v11 production deployments, not nice really... (Blessed be tests!)

Well I think we just need another configuration variable. I've now exhausted all the ones that exist in Odoo, so I'll just make one up I think

lasley · 2017-12-15T18:14:01Z

Well hmmmm- I put this command last in the stack in hopes that it would be after a DB creation, but that does not seem to be the case. I'm not sure I understand this testing architecture/flow TBH

yajo

Much nicer!

Now we have 2 failures, outlined below.

yajo · 2017-12-18T08:52:33Z

11.0.Dockerfile

+ONBUILD ARG ODOO_LIMIT_TIME_REAL_CRON=-1
+ONBUILD ARG ODOO_DB_FILTER=""
+ONBUILD ARG ODOO_LIST_DB=1
+ONBUILD ARG ODOO_LOG_LEVEL=info


You forgot to translate these ARG into ENV, like in the v8 dockerfile. That's the cause of v11 failure.

yajo · 2017-12-18T08:55:40Z

tests/__init__.py

@@ -192,6 +192,8 @@ def test_dotd(self):
                ("odoo", "--version"),
                # Implicit ``odoo`` command also works
                ("--version",),
+                # Environment vars were converted to config
+                ( "custom/extras/goodconf.py", ),


It seems that odoo shell does not autocreate a database like normal odoo commands do from v9+. Then you can change this for ("bash", "-c", "odoo --stop-after-init && custom/extras/goodconf.py") or something similar that creates the DB before executing the shell script.

yajo · 2017-12-19T08:30:34Z

Yikes! Well, now we're getting into it. 😉

The test_dotd() test didn't have a single test that needed a present Odoo DB.

Now that we need it to create a Odoo db, we need to make the required steps for it. It seems we're hitting 2 problems:

In v8, you still need to precreate the database. You don't have to do it in higher versions, so we need a way to run that step only in v8, and the testing suite provides such tool. You need to imitate what test_smallest() does: https://github.com/Tecnativa/docker-odoo-base/blob/318cf1a65c6977418299e7936d68fcde72c19ef3/tests/__init__.py#L147-L155
In v9+ the logs appear to indicate that the __manifest__.py or __openerp__.py files are empty. You can choose between actually filling those files found in the dotd scaffolding, or add a new scaffolding folder to only test the config builder. Maybe the latter would be easier.

yajo · 2018-01-10T16:32:26Z

I'm not sure if problem 2 would be fixed with a rebase now...

lasley · 2018-01-10T22:47:31Z

Hmmm so v8 is still failing due to no db, but I very clearly see the create database command success from Postgres. I'm taking a total stab in the dark, but I'm thinking there's a different PSQL container for each matrix iteration, so I just created the db in all versions instead 🤷‍♂️

yajo · 2018-01-11T11:29:13Z

tests/scaffoldings/dotd/custom/extras/goodconf.py

@@ -0,0 +1,4 @@
+#!/usr/local/bin/python-odoo-shell
+from odoo.tools import config
+assert config.get("test_config_setting") == "Over9000"


It says line 3 fails, so this is possibly not doing what you expect.

I'm actually not sure why I'm even created that file or tested this part. Totally unrelated to the task at hand. Fixed.

If tests pass though, I think this might mean there's an issue with config generation in the custom directories.

yajo · 2018-01-15T12:34:34Z

tests/scaffoldings/dotd/custom/extras/goodconf.py

@@ -0,0 +1,4 @@
+#!/usr/local/bin/python-odoo-shell
+from odoo.tools import config
+assert config.get("limit_request") == "8000"


This still fails on line 3.

I'm suspecting that duplicate keys cannot be correctly parsed, or that the parameter is converted to int and thus this assertion fails.

Maybe could you add assertion messages that help us to debug further? Example:

assert config.get("limit_request") == 8000, "%r is not %r" % (config.get("limit_request"), 8000)

... and the same in line 4

yajo · 2018-01-25T09:33:14Z

Hi friend, I added a scaffolding just to test settings in 52ad126, and it always uses a database. It's only testing versions >= 9.0 because older did not have odoo shell.

Most likely you can take advantage of that to do the tests in an easier way 😊

* Add some more configurations, use the defaults from https://github.com/odoo/odoo/blob/3ace806d399e9e3abc5ada84ba98d2de100388d3/odoo/tools/config.py#L277

yajo · 2018-01-29T09:12:46Z

8.0.Dockerfile

+            ODOO_DB_FILTER="$ODOO_DB_FILTER" \
+            ODOO_LIST_DB="$ODOO_LIST_DB" \
+            ODOO_LOG_LEVEL="$ODOO_LOG_LEVEL"
+>>>>>>> [IMP] Add some more default configurations


oops.. wrong rebase

yajo · 2018-01-29T09:13:09Z

tests/__init__.py

@@ -140,6 +140,9 @@ def test_settings(self):
            ("--stop-after-init",),
            # SMTP settings work
            ("./custom/scripts/test_smtp_settings.py",),
+            # Environment vars were converted to config
+            ("bash", "-c",
+             "odoo --stop-after-init && custom/extras/goodconf.py"),


The --stop-after-init is done above, just call goodconf

yajo · 2018-10-08T07:41:59Z

This is very outdated and stale. Closing.

See https://forums.aws.amazon.com/ann.jspa?annID=6776 closes Tecnativa#60

This reverts commit 1bf8a8f.

yajo suggested changes Jul 31, 2017

View reviewed changes

yajo reviewed Jul 31, 2017

View reviewed changes

yajo suggested changes Jul 31, 2017

View reviewed changes

lasley force-pushed the feature/more-config-options branch from 2616095 to 567152f Compare July 31, 2017 18:32

lasley force-pushed the feature/more-config-options branch from 1d0148c to 875d00b Compare August 4, 2017 15:47

yajo suggested changes Aug 7, 2017

View reviewed changes

lasley force-pushed the feature/more-config-options branch 2 times, most recently from 0c28b68 to 0977cb1 Compare August 8, 2017 21:16

yajo suggested changes Aug 9, 2017

View reviewed changes

lasley force-pushed the feature/more-config-options branch from 0977cb1 to 1bbbce9 Compare August 9, 2017 16:36

lasley force-pushed the feature/more-config-options branch from 1bbbce9 to 1be3608 Compare August 10, 2017 17:43

lasley mentioned this pull request Aug 24, 2017

[IMP] Add option to automatically install repo requirements #71

Merged

lasley mentioned this pull request Sep 25, 2017

add db-filter as parameter to odoo initialization #83

Closed

yajo force-pushed the master branch 4 times, most recently from dd2bfdd to daad1d0 Compare October 4, 2017 15:58

yajo force-pushed the master branch 2 times, most recently from 635050e to e88faa0 Compare October 5, 2017 07:20

yajo suggested changes Nov 15, 2017

View reviewed changes

lasley force-pushed the feature/more-config-options branch from 1be3608 to 3aeac3f Compare December 12, 2017 21:36

yajo suggested changes Dec 13, 2017

View reviewed changes

yajo suggested changes Dec 14, 2017

View reviewed changes

yajo suggested changes Dec 15, 2017

View reviewed changes

yajo suggested changes Dec 18, 2017

View reviewed changes

lasley force-pushed the feature/more-config-options branch from 1e04e60 to 720592b Compare January 10, 2018 22:15

yajo reviewed Jan 11, 2018

View reviewed changes

yajo suggested changes Jan 15, 2018

View reviewed changes

yajo mentioned this pull request Jan 24, 2018

[NEW] enable advanced SMTP config #110

Merged

[IMP] Add some more default configurations

5178916

* Add some more configurations, use the defaults from https://github.com/odoo/odoo/blob/3ace806d399e9e3abc5ada84ba98d2de100388d3/odoo/tools/config.py#L277

lasley force-pushed the feature/more-config-options branch from 7ab819e to 5178916 Compare January 26, 2018 18:06

Move test

7ebfdfb

yajo suggested changes Jan 29, 2018

View reviewed changes

yajo closed this Oct 8, 2018

tfossoul pushed a commit to tfossoul/doodba that referenced this pull request Jan 20, 2020

Switch to new S3 URI (Tecnativa#62)

1bf8a8f

See https://forums.aws.amazon.com/ann.jspa?annID=6776 closes Tecnativa#60

tfossoul pushed a commit to tfossoul/doodba that referenced this pull request Jan 20, 2020

Revert "Switch to new S3 URI (Tecnativa#62)"

345a61e

This reverts commit 1bf8a8f.

		@@ -0,0 +1,4 @@
		#!/usr/local/bin/python-odoo-shell
		from odoo.tools import config

		@@ -0,0 +1,2 @@
		[options]
		log_level=$ODOO_LOG_LEVEL

[IMP] Add some more default configurations #62

[IMP] Add some more default configurations #62

Conversation

lasley commented Jul 28, 2017 • edited by pedrobaeza Loading

yajo left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 31, 2017

Choose a reason for hiding this comment

lasley Jul 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Aug 2, 2017

lasley commented Aug 2, 2017

yajo commented Aug 4, 2017

lasley commented Aug 4, 2017

yajo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Aug 7, 2017 • edited Loading

lasley commented Aug 7, 2017

yajo commented Aug 8, 2017

lasley commented Aug 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Aug 9, 2017

yajo commented Aug 10, 2017

lasley commented Aug 24, 2017

yajo commented Aug 25, 2017

lasley commented Nov 14, 2017

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Dec 12, 2017

lasley commented Dec 12, 2017

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Dec 13, 2017

yajo left a comment

Choose a reason for hiding this comment

lasley commented Dec 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Dec 15, 2017 • edited Loading

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Dec 19, 2017

yajo commented Jan 10, 2018

lasley commented Jan 10, 2018

Choose a reason for hiding this comment

lasley Jan 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Jan 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Oct 8, 2018

lasley commented Jul 28, 2017 •

edited by pedrobaeza

Loading

lasley Jul 31, 2017 •

edited

Loading

yajo left a comment •

edited

Loading

lasley commented Aug 7, 2017 •

edited

Loading

lasley commented Dec 15, 2017 •

edited

Loading

lasley Jan 11, 2018 •

edited

Loading