This repository has been archived by the owner on Apr 13, 2020. It is now read-only.
[DCK] Remove outdated samples #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still want an OCA addons sample with the origin name and so on. I know that documentation is there, but this is for a copy/paste helper and good practices for names. |
|
The scaffolding is IMHO not a good place to put code snippets, mostly those that are going to be removed very likely. With the goal to keep it as small and useful as possible, if you want I can include a link to the relevant part of the docs where you can copy a snippet from. OTOH, I would be glad to add a snippet for the repos.yaml file in the |
|
OK for both suggestions |
yajo
force-pushed
the
simpler-samples
branch
2 times, most recently
from
2b32040 to
82d6e06
Compare
|
Now it's cool: |
|
Great! |
- `l10n-spain` was never a good sample, since only Spanish projects would have it. Since Tecnativa/doodba#86 it's simply not needed in most cases. Devs can check the docs to know the structure, and a vscode snippet has been added. Thus, it can be removed from here. - `checksumdir` is not used anymore in `module_auto_update` since OCA/server-tools#1190. - `xlsxwriter` is included in Odoo 10+. - `requests` is included in Odoo 8+.
yajo
force-pushed
the
simpler-samples
branch
from
82d6e06 to
17bbb90
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
l10n-spainwas never a good sample, since only Spanish projects would have it. Since [WIP] Autogenerate repos.yaml for missing addons doodba#86 it's simply not needed in most cases. Devs can check the docs to know the structure. Thus, it can be removed from here.checksumdiris not used anymore inmodule_auto_updatesince [REF] module_auto_update: Deprecate buggy features, add new API OCA/server-tools#1190.xlsxwriteris included in Odoo 10+.requestsis included in Odoo 8+.