#31 ⬆️ update to parent version 10 (JDK 17, default Python fo… #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
commented
Sep 19, 2024
| @@ -5,16 +5,17 @@ class LogManager: | |||
| """ | |||
| Class for handling logging. | |||
| """ | |||
There was a problem hiding this comment.
I (Informational): this came from running the latest version of Habushu on the existing codebase
| @@ -28,6 +29,13 @@ public void testEncryptedPropertyReadProvidesDecryptedValue() { | |||
| krausening.loadProperties(); | |||
| Properties properties = krausening.getProperties(ENCRYPTED_PROPERTIES); | |||
| assertNotNull(properties); | |||
There was a problem hiding this comment.
I: the lamba breaks things with the encryptor (and arguably shouldn't be in this imperative codebase anyway)
csun-cpointe
approved these changes
Sep 19, 2024
meliz19
reviewed
Sep 19, 2024
| @@ -18,6 +18,9 @@ | |||
| <plugin> | |||
| <groupId>org.technologybrewery.habushu</groupId> | |||
| <artifactId>habushu-maven-plugin</artifactId> | |||
| <configuration> | |||
| <pythonVersion>${version.python.default}</pythonVersion> | |||
| </configuration> | |||
| </plugin> | |||
There was a problem hiding this comment.
Q: Will this change the value of the current version of the project in the pyproject.toml?
There was a problem hiding this comment.
No - this is the version that we'll use to build only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r building to 3.11.9)