Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Front-end: When user clicks on "accept" a group it is considered as "declined" #618

Closed
OrAbramovich opened this issue Jun 22, 2018 · 5 comments
Closed

Bug: Front-end: When user clicks on "accept" a group it is considered as "declined" #618

OrAbramovich opened this issue Jun 22, 2018 · 5 comments
Assignees
@OrAbramovich
Labels
Back-End Bug Front-End
Milestone
End of Semester Demo

Comments

@OrAbramovich
Copy link
Collaborator

No description provided.

@OrAbramovich OrAbramovich added this to the End of Semester Demo milestone Jun 22, 2018
@OrAbramovich OrAbramovich self-assigned this Jun 22, 2018
@OrAbramovich
Copy link
Collaborator Author

Estimated time: 0.5 hour (incl. tests)

@OrAbramovich OrAbramovich changed the title Bug: Front-end: When user clicks on "accept" a group it is considered as "declined" Bug: Back-end: Front-end: When user clicks on "accept" a group it is considered as "declined" Jun 22, 2018
@alonttal
Copy link
Collaborator

There are already tests that check that. Are you sure this is not front-end issue?

@OrAbramovich
Copy link
Collaborator Author

OrAbramovich commented Jun 22, 2018 •
edited
Loading

It's front-end, there is a mismatch between the enums

@OrAbramovich OrAbramovich changed the title Bug: Back-end: Front-end: When user clicks on "accept" a group it is considered as "declined" Bug: Front-end: When user clicks on "accept" a group it is considered as "declined" Jun 22, 2018
OrAbramovich added a commit that referenced this issue Jun 22, 2018
@OrAbramovich
Fixed: Bug: Front-end: When user clicks on "accept" a group it is con…
1459dcb 
…sidered as "declined"

Problem was - mismatch between enums (one in front-end and one in back-end).
Aligned member status enum and group status enum to be in the same order.

#618
@OrAbramovich
Copy link
Collaborator Author

actual time: 0.5 hour (incl. manual test)

@OrAbramovich
Copy link
Collaborator Author

Done.

This was referenced Jun 22, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrAbramovich OrAbramovich

Labels
Back-End Bug Front-End
Projects
None yet
Milestone
End of Semester Demo
Development

No branches or pull requests
2 participants
@OrAbramovich @alonttal