Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Weird chat behavior #617

Closed
idanyadgar opened this issue Jun 21, 2018 · 5 comments
Closed

Bug: Weird chat behavior #617

idanyadgar opened this issue Jun 21, 2018 · 5 comments

Comments

@idanyadgar
Copy link
Contributor

idanyadgar commented Jun 21, 2018

Messages sent from A to B appear once from A point of view but are received 4 times at B and are not saved in the DB (on refresh we don't see them).

@idanyadgar
Copy link
Contributor Author

@OrAbramovich I'll need your help here.

@idanyadgar idanyadgar added this to the End of Semester Demo milestone Jun 21, 2018
@alonttal
Copy link
Collaborator

hi @idanyadgar
whats the status for this?

@idanyadgar
Copy link
Contributor Author

@alonttal Same.

OrAbramovich added a commit that referenced this issue Jun 22, 2018
Probably caused by a merge issue - there were 2 handlers for each message. Anyway - added another check (to != current user).

#617
@OrAbramovich
Copy link
Collaborator

Hi @idanyadgar ,

Reproduced on my machine.

Probably caused by a merge issue - there were 2 handlers for each message. Anyway - added another check (to != current user) - I pushed the changes to private-messaging branch (only).

Can you verify it? (pay attention! checking it on Azure requires a merge with your branch and with the master since the Azure site uses the cloud db that contains new types of notifications, etc. hence - you can get errors with your branch because your back-end is not familiar with those types).

Shabat Shalom.

@idanyadgar
Copy link
Contributor Author

Yes, that was it.
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants