Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back-end: Change current flow & supported messages of the sockets server according to the new design #345

Closed
OrAbramovich opened this issue Apr 29, 2018 · 3 comments
Closed

Back-end: Change current flow & supported messages of the sockets server according to the new design #345

OrAbramovich opened this issue Apr 29, 2018 · 3 comments
Assignees
@OrAbramovich
Labels
Back-End
Milestone
Mid Semester POC

Comments

@OrAbramovich
Copy link
Collaborator

Change the sockets server according to the new design available @ our Wiki: https://github.com/TechnionYearlyProject/Roommates/wiki/Sockets-Server-Design-&-Implementation-Details-Document
@OrAbramovich OrAbramovich added this to the Mid Semester POC milestone Apr 29, 2018
@OrAbramovich OrAbramovich self-assigned this Apr 29, 2018
@OrAbramovich
Copy link
Collaborator Author

Estimated time: 0.5 hour.

OrAbramovich added a commit that referenced this issue Apr 29, 2018
@OrAbramovich
Back-end: Changed current flow & added supported messages of the sock…
78bd529 
…ets server according to the new design

This commit includes minor changes required following the new design available at the project Wiki:

The new flow - only one room is opened for each user with his id as the name. User cannot join multiple rooms, all messages will be sent to the single room.

Added new supported messages types and changed their names to be text instead of int code so it would be more readable on front-end.

#345
@OrAbramovich OrAbramovich mentioned this issue Apr 29, 2018
Open
@OrAbramovich
Copy link
Collaborator Author

Actual time: 0.5 hour.

@OrAbramovich
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrAbramovich OrAbramovich

Labels
Back-End
Projects
None yet
Milestone
Mid Semester POC
Development

No branches or pull requests
1 participant
@OrAbramovich