Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[php] Update Codeigniter to v 4 #7686

Merged
merged 4 commits into from
Nov 16, 2022
Merged

[php] Update Codeigniter to v 4 #7686

merged 4 commits into from
Nov 16, 2022

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Nov 10, 2022 •
edited
Loading

It's a complete rewrite because it's BC, and added update test.

#6894

@joanhey joanhey mentioned this pull request Nov 10, 2022
Closed
17 tasks
@joanhey
Copy link
Contributor Author

joanhey commented Nov 11, 2022 •
edited
Loading

Performance info

CI3 vs CI4

Framework JSON 1-query 20-query Fortunes Updates Plaintext
CI3 26,313 25,189 12,049 24,358 -- 25,646
CI4 5,746 5,314 4,244 5,320 2,086 5,791

@NateBrady23 NateBrady23 merged commit 297d1e4 into TechEmpower:master Nov 16, 2022
@joanhey joanhey deleted the codeigniter4 branch November 17, 2022 15:47
@joanhey joanhey mentioned this pull request Nov 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Please Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanhey @NateBrady23