-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Introduce userver #7617
[C++] Introduce userver #7617
Conversation
@apolukhin @userver-framework can you guys please have a look at this? There def. are some configurations tweaks to make, but i'm not yet certain which ones exactly - guess it can be done after merging this PR and seeing benchmark results. |
A few nitpicks for later changes:
|
Fixed userver spelling, added
|
@nbrady-techempower Hi! Could you please have a look at this? |
We use it quite a lot in production for serializing responses. It's an interface for streaming serializer (SAX), which is a quite a common technique. There's also a separate section in docs with a sample for SAX streaming https://userver.tech/db/dd7/md_en_userver_formats.html#streamingserialization . However, it may not provide notable advantage for small responses. |
userver::formats::json::Type::kObject}; | ||
builder["id"] = row.id; | ||
builder["randomNumber"] = row.random_number; | ||
return builder.ExtractValue(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an inline builder (formats::json::MakeDoc
) should perform better here
* add queries/updates tests
* restructure project * add cached-queries
Not sure what went wrong here, runs fine in my action queue: itrofimow#1 @nbrady-techempower could you please rerun failing checks for me? |
Hi @nbrady-techempower! Is there anything holding this PR back from being merged? |
This PR aims to incorporate https://github.com/userver-framework/userver into benchmark suite