Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply to spec on queries number for test type 3 #751

Merged
merged 3 commits into from
Jan 16, 2014
Merged

Comply to spec on queries number for test type 3 #751

merged 3 commits into from
Jan 16, 2014

Conversation

nanocom
Copy link
Contributor

@nanocom nanocom commented Jan 16, 2014

Queries number must be between 1 and 500, as specified.

queries number must be between 1 and 500.
@nanocom
Copy link
Contributor Author

nanocom commented Jan 16, 2014

CF. discussions on PR #650

Same commit as for symfony2 not stripped.
@nanocom
Copy link
Contributor Author

nanocom commented Jan 16, 2014

This PR should resolve all the warnings seen in https://gist.github.com/msmith-techempower/8442705

@msmith-techempower
Copy link
Member

You are properly clamping the output between 1-500 objects now, but query requires the results to be in an array regardless of length.

This differs from the db test in that db is always going to be a single JSON object while query is always an array.

@nanocom
Copy link
Contributor Author

nanocom commented Jan 16, 2014

Should do the trick.

msmith-techempower added a commit that referenced this pull request Jan 16, 2014
Comply to spec on queries number for test type 3
@msmith-techempower msmith-techempower merged commit f97a352 into TechEmpower:master Jan 16, 2014
@nanocom nanocom deleted the patch-2 branch January 17, 2014 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants