Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Tornado from 5.1.1 to 6.0 #4498

Closed
wants to merge 6 commits into from
Closed

update Tornado from 5.1.1 to 6.0 #4498

wants to merge 6 commits into from

Conversation

MioYvo
Copy link
Contributor

@MioYvo MioYvo commented Mar 3, 2019

New big version of Tornado has been released. Some changes may improve performance.

https://www.tornadoweb.org/en/stable/releases/v6.0.0.html

@MioYvo
Copy link
Contributor Author

MioYvo commented Mar 3, 2019

error details from local and travis-ci :

  File "/FrameworkBenchmarks/toolset/utils/docker_helper.py", line 14, in <module>
    from psutil import virtual_memory
ImportError: No module named psutil

Seems tools of tfb is broken.

@MioYvo
Copy link
Contributor Author

MioYvo commented Mar 3, 2019

Maybe we need to rebuild and upload a new image techempower/tfb:latest to dockerhub to make #4494 effective.

@NateBrady23
Copy link
Member

Yeah this is our mistake. We're actually not using dockerhub for the image anymore. Fix incoming; thanks.

@NateBrady23
Copy link
Member

@MioYvo You can merge in the current master branch to fix the travis issues

@MioYvo
Copy link
Contributor Author

MioYvo commented Mar 5, 2019

I did a wrong git merge and push.Close this PR. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants