Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onyx multiple queries benchmark violation #4842

Closed
fafhrd91 opened this issue Jun 9, 2019 · 5 comments · Fixed by #4845
Closed

onyx multiple queries benchmark violation #4842

fafhrd91 opened this issue Jun 9, 2019 · 5 comments · Fixed by #4845
Assignees
@michaelhixson

Comments

@fafhrd91
Copy link
Contributor

fafhrd91 commented Jun 9, 2019

onyx framework executes one query per request for multiple queries benchmark
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Crystal/onyx/src/endpoints/worlds/many.cr#L5
@NateBrady23
Copy link
Member

NateBrady23 commented Jun 9, 2019 •
edited
Loading

@vladfaust Do you have any time to fix this? We'll have to remove this from any official results.

https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#multiple-database-queries

@vladfaust
Copy link
Contributor

Feel free to remove it for now, I'll re-add it some time later. Thanks!

@michaelhixson
Copy link
Contributor

@fafhrd91 Thanks. Confirmed by enabling postgres query logs locally.

Accessing URL http://tfb-server:8080/queries?queries=2:
2019-06-10 19:35:38 GMT LOG:  execute <unnamed>: SELECT * FROM world WHERE (id = ANY($1))
2019-06-10 19:35:38 GMT DETAIL:  parameters: $1 = '{3473,6467}'

@sebastienros
Copy link
Contributor

Could this be part of the CI tests?

@msmith-techempower
Copy link
Member

Could this be part of the CI tests?

That's a great idea.

michaelhixson added a commit to michaelhixson/FrameworkBenchmarks that referenced this issue Jun 10, 2019
@michaelhixson
Make onyx multi-query and updates test implementations compliant
e33fb37 
Fixes TechEmpower#4842

The updates test implementation was also non-compliant because it was not
selecting worlds from the database.  Instead, it was generating new world
objects in memory with random attributes.
@michaelhixson michaelhixson mentioned this issue Jun 10, 2019
Merged
@michaelhixson michaelhixson self-assigned this Jun 10, 2019
NateBrady23 pushed a commit that referenced this issue Jun 11, 2019
@michaelhixson @NateBrady23
Make onyx multi-query and updates test implementations compliant (#4845)
086fabd 
Fixes #4842

The updates test implementation was also non-compliant because it was not
selecting worlds from the database.  Instead, it was generating new world
objects in memory with random attributes.
@NateBrady23 NateBrady23 mentioned this issue Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelhixson michaelhixson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make onyx multi-query and updates test implementations compliant michaelhixson/FrameworkBenchmarks
6 participants
@michaelhixson @fafhrd91 @sebastienros @NateBrady23 @msmith-techempower @vladfaust