Merge pull request #8 from abevoelker/update-ruby-examples

Use map instead of side-effecting each for Ruby benchmarks
TechEmpower · Mar 28, 2013 · 3376a97 · 3376a97
2 parents abe639c + 5d7e843
commit 3376a97
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/rails/app/controllers/hello_world_controller.rb b/rails/app/controllers/hello_world_controller.rb
@@ -4,13 +4,12 @@ def json
   end
 
   def db
-    queries = params[:queries] || 1
+    queries = (params[:queries] || 1).to_i
 
-    results = []
-    (1..queries.to_i).each do
+    results = (1..queries).map do
       # get a random row from the database, which we know has 10000
       # rows with ids 1 - 10000
-      results << World.find(Random.rand(10000) + 1)
+      World.find(Random.rand(10000) + 1)
     end
     render :json => results
   end

diff --git a/sinatra/hello_world.rb b/sinatra/hello_world.rb
@@ -21,11 +21,10 @@ class World < ActiveRecord::Base
 end
 
 get '/db' do
-  queries = params[:queries] || 1
+  queries = (params[:queries] || 1).to_i
 
-  results = []
-  (1..queries.to_i).each do
-    results << World.find(Random.rand(10000) + 1)
+  results = (1..queries).map do
+    World.find(Random.rand(10000) + 1)
   end
 
   results.to_json