Delegating command preparation to the driver (#8) (#3297)

TechEmpower · Feb 19, 2018 · 14ad208 · 14ad208
1 parent bb7c02d
commit 14ad208
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/frameworks/CSharp/aspnetcore/Benchmarks/Data/DapperDb.cs b/frameworks/CSharp/aspnetcore/Benchmarks/Data/DapperDb.cs
@@ -37,9 +37,9 @@ public async Task<World> LoadSingleQueryRow()
             }
         }
 
-        async Task<World> ReadSingleRow(DbConnection db)
+        Task<World> ReadSingleRow(DbConnection db)
         {
-            return await db.QueryFirstOrDefaultAsync<World>(
+            return db.QueryFirstOrDefaultAsync<World>(
                     "SELECT id, randomnumber FROM world WHERE id = @Id",
                     new { Id = _random.Next(1, 10001) });
         }

diff --git a/frameworks/CSharp/aspnetcore/Benchmarks/Data/RawDb.cs b/frameworks/CSharp/aspnetcore/Benchmarks/Data/RawDb.cs
@@ -63,10 +63,6 @@ DbCommand CreateReadCommand(DbConnection connection)
             id.Value = _random.Next(1, 10001);
             cmd.Parameters.Add(id);
 
-            // Prepared statements improve PostgreSQL performance by 10-15%
-            // Especially if you only call them once, instead of on every execution :)
-            cmd.Prepare();
-
             return cmd;
         }
 
@@ -135,7 +131,6 @@ public async Task<World[]> LoadMultipleUpdatesRows(int count)
                     }
 
                     updateCmd.CommandText = updateCommand.ToString();
-                    updateCmd.Prepare();
                     await updateCmd.ExecuteNonQueryAsync();
                 }
             }
@@ -155,9 +150,6 @@ public async Task<IEnumerable<Fortune>> LoadFortunesRows()
                 db.ConnectionString = _connectionString;
                 await db.OpenAsync();
 
-                // Prepared statements improve PostgreSQL performance by 10-15%
-                cmd.Prepare();
-
                 using (var rdr = await cmd.ExecuteReaderAsync(CommandBehavior.CloseConnection))
                 {
                     while (await rdr.ReadAsync())

diff --git a/frameworks/CSharp/aspnetcore/Benchmarks/appsettings.postgresql.json b/frameworks/CSharp/aspnetcore/Benchmarks/appsettings.postgresql.json
@@ -1,4 +1,4 @@
 {
-  "ConnectionString": "Server={db_server_placeholder};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=1024;NoResetOnClose=true",
+  "ConnectionString": "Server={db_server_placeholder};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=1024;NoResetOnClose=true;Max Auto Prepare=3",
   "Database": "postgresql"
 }