Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghactions support #118

Merged
merged 6 commits into from
Dec 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: CI

on: [push, pull_request]
on: [push]
jobs:
build:
strategy:
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
node-version: ["0.12", "4.9", "8.17", "14.0"]
node-version: ["4", "8", "14"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop 4 and 8 at least and add 18 and 20 instead. I don't know about 14, it doesn't receive security support anymore since last April. And for the missing 16, it doesn't receive security support either since last September, but it's the last LTS version out the door, so I don't know. Maybe add it for now.


runs-on: ${{ matrix.os }}