유저 테스트 코드 작성 (#120)

* #119 test: userRepository 테스트 코드 작성 - findByUserToken() - existsByEmail() - findByEmail() - findAllByUserToken() - findAllByUserId() * #119 test: userService 테스트 코드 작성 - updateMyInfo() - nullExceptionUpdateMyInfo() - search() * #119 fix: 유저 find 기능 수정 - findAllByUserToken() - findAllByUserId()
TeamSynergyy · Sep 5, 2024 · 5becb60 · 5becb60
1 parent ade3d9c
commit 5becb60
Show file tree

Hide file tree

Showing 10 changed files with 268 additions and 35 deletions.
diff --git a/src/main/java/com/seoultech/synergybe/domain/email/MailService.java b/src/main/java/com/seoultech/synergybe/domain/email/MailService.java
@@ -1,6 +1,5 @@
 package com.seoultech.synergybe.domain.email;
 
-import com.seoultech.synergybe.domain.common.RandomNumber;
 import com.seoultech.synergybe.system.utils.RedisUtil;
 import jakarta.mail.MessagingException;
 import jakarta.mail.internet.MimeMessage;

diff --git a/src/main/java/com/seoultech/synergybe/domain/user/User.java b/src/main/java/com/seoultech/synergybe/domain/user/User.java
@@ -60,6 +60,7 @@ public void updateUserInfo(
             String name,
             String major
     ) {
+        if (userToken == null || email == null || name == null || major == null) throw new NullPointerException();
         this.email = this.email.updateEmail(email);
         this.name = this.name.updateName(name);
         this.major = this.major.updateMajor(major);

diff --git a/src/main/java/com/seoultech/synergybe/domain/user/controller/UserController.java b/src/main/java/com/seoultech/synergybe/domain/user/controller/UserController.java
@@ -71,7 +71,6 @@ public ResponseEntity<GetUserAccountResponse> getUser(@PathVariable("userId") St
     @Operation(summary = "검색어를 포함하는 유자", description = "검색어를 포함하는 유저가 반환됩니다.")
     @GetMapping
     public ResponseEntity<Page<User>> searchAllPosts(@RequestParam("search") String search, @PageableDefault(size = 15) Pageable pageable) {
-        log.info(">> keyword : {}", search);
 
         return ResponseEntity.status(HttpStatus.OK).body(userService.searchAllUsers(search, pageable));
     }

diff --git a/src/main/java/com/seoultech/synergybe/domain/user/repository/UserRepository.java b/src/main/java/com/seoultech/synergybe/domain/user/repository/UserRepository.java
@@ -6,25 +6,14 @@
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.domain.Specification;
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.Query;
-import org.springframework.data.repository.query.Param;
 import org.springframework.stereotype.Repository;
 
-import java.util.List;
 import java.util.Optional;
 
 @Repository
 public interface UserRepository extends JpaRepository<User, Long>, UserRepositoryCustom {
-
-    @Query(value = "SELECT * FROM user WHERE user_id IN :userIds", nativeQuery = true)
-    List<User> findAllByUserId(@Param("userIds") List<Long> userIds);
-
     Page<User> findAll(Specification<User> spec, Pageable pageable);
-
     boolean existsByEmail(UserEmail email);
-
     Optional<User> findByUserToken(String userToken);
 
-    @Query(value = "SELECT * FROM user WHERE user_id IN :userToken", nativeQuery = true)
-    List<User> findAllByUserToken(@Param("userToken") List<String> userToken);
 }
diff --git a/src/main/java/com/seoultech/synergybe/domain/user/repository/UserRepositoryCustom.java b/src/main/java/com/seoultech/synergybe/domain/user/repository/UserRepositoryCustom.java
@@ -1,10 +1,11 @@
 package com.seoultech.synergybe.domain.user.repository;
 
 import com.seoultech.synergybe.domain.user.User;
-import com.seoultech.synergybe.domain.user.dto.response.GetUserAccountResponse;
 
-public interface UserRepositoryCustom {
-    GetUserAccountResponse findUserAccountByEmail(String email);
+import java.util.List;
 
+public interface UserRepositoryCustom {
     User findByEmail(String email);
+    List<User> findAllByUserToken(List<String> userToken);
+    List<User> findAllByUserId(List<Long> userIds);
 }
diff --git a/src/main/java/com/seoultech/synergybe/domain/user/repository/UserRepositoryCustomImpl.java b/src/main/java/com/seoultech/synergybe/domain/user/repository/UserRepositoryCustomImpl.java
@@ -2,30 +2,19 @@
 
 import com.querydsl.jpa.impl.JPAQueryFactory;
 import com.seoultech.synergybe.domain.user.User;
-import com.seoultech.synergybe.domain.user.dto.response.GetUserAccountResponse;
-import com.seoultech.synergybe.domain.user.dto.response.QGetUserAccountResponse;
 import com.seoultech.synergybe.domain.user.vo.UserEmail;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Repository;
 
+import java.util.List;
+
 import static com.seoultech.synergybe.domain.user.QUser.user;
 
 @RequiredArgsConstructor
 @Repository
 public class UserRepositoryCustomImpl implements UserRepositoryCustom {
     private final JPAQueryFactory queryFactory;
 
-    @Override
-    public GetUserAccountResponse findUserAccountByEmail(String email) {
-//        User user1 = queryFactory
-//                .select(user)
-//                .from(user)
-//                .where(user.email.eq)
-//                .fetchOne();
-        GetUserAccountResponse getUserAccountResponse = GetUserAccountResponse.builder().build();
-        return getUserAccountResponse;
-    }
-
     @Override
     public User findByEmail(String email) {
         UserEmail userEmail = new UserEmail(email);
@@ -34,4 +23,20 @@ public User findByEmail(String email) {
                 .where(user.email.eq(userEmail))
                 .fetchOne();
     }
+
+    @Override
+    public List<User> findAllByUserToken(List<String> userToken) {
+        return queryFactory
+                .selectFrom(user)
+                .where(user.userToken.in(userToken))
+                .fetch();
+    }
+
+    @Override
+    public List<User> findAllByUserId(List<Long> userIds) {
+        return queryFactory
+                .selectFrom(user)
+                .where(user.id.in(userIds))
+                .fetch();
+    }
 }
diff --git a/src/main/java/com/seoultech/synergybe/domain/user/service/UserServiceImpl.java b/src/main/java/com/seoultech/synergybe/domain/user/service/UserServiceImpl.java
@@ -157,12 +157,12 @@ public Predicate toPredicate(Root<User> userRoot, CriteriaQuery<?> query, Criter
 
     @Transactional
     public void updateMyInfo(
-            String userId,
+            String userToken,
             String email,
             String name,
             String major
     ) {
-        User user = getUserByToken(userId);
+        User user = getUserByToken(userToken);
         user.updateUserInfo(email, name, major);
     }
 
@@ -251,7 +251,7 @@ public void generateAccessTokenByRefreshToken(HttpServletRequest request, HttpSe
     public List<Long> getUserIds(List<String> userToken) {
         List<User> users = userRepository.findAllByUserToken(userToken);
 
-        List<Long> userIds = users.stream().map(user -> user.getId()).toList();
+        List<Long> userIds = users.stream().map(User::getId).toList();
         return userIds;
     }
 }

diff --git a/src/test/java/com/seoultech/synergybe/domain/common/generator/TokenGeneratorUUIDTest.java b/src/test/java/com/seoultech/synergybe/domain/common/generator/TokenGeneratorUUIDTest.java
@@ -23,7 +23,6 @@ class TokenGeneratorUUIDTest {
     void generateLongId() {
         List<Long> longList = new ArrayList<>();
 
-        // test start
         long startTime = System.currentTimeMillis();
 
         for (int i = 0; i < 10000; i++) {
@@ -44,15 +43,13 @@ void generateLongId() {
     void generateStringId() {
         List<String> stringList = new ArrayList<>();
 
-        // test start
         long startTime = System.currentTimeMillis();
 
         for (int i = 0; i < 10000; i++) {
             String stringId = tokenGenerator.generateToken(IdPrefix.POST);
             stringList.add(stringId);
         }
 
-        // test end
         long endTime = System.currentTimeMillis();
         long elapsedTime = endTime - startTime;
 

diff --git a/src/test/java/com/seoultech/synergybe/domain/user/UserRepositoryTest.java b/src/test/java/com/seoultech/synergybe/domain/user/UserRepositoryTest.java
@@ -0,0 +1,158 @@
+package com.seoultech.synergybe.domain.user;
+
+import com.seoultech.synergybe.domain.common.CustomPasswordEncoder;
+import com.seoultech.synergybe.domain.user.repository.UserRepository;
+import com.seoultech.synergybe.domain.user.vo.UserEmail;
+import jakarta.transaction.Transactional;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+@SpringBootTest
+@Transactional
+public class UserRepositoryTest {
+    @Autowired
+    private UserRepository userRepository;
+
+    @Autowired
+    private CustomPasswordEncoder passwordEncoder;
+
+    @Test
+    void findByUserToken() {
+        // given
+        String userToken = "usr_token";
+        User user = User.builder()
+                .id(1L)
+                .userToken(userToken)
+                .email("[email protected]")
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+        userRepository.save(user);
+
+        // when
+        User savedUser = userRepository.findByUserToken(userToken).orElseThrow();
+
+        // then
+        assertThat(savedUser.getUserToken()).isEqualTo(userToken);
+    }
+
+    @Test
+    void existsByEmail() {
+        // given
+        String userEmail = "[email protected]";
+        User user = User.builder()
+                .id(1L)
+                .userToken("userToken")
+                .email(userEmail)
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+        userRepository.save(user);
+        UserEmail userEmailEmbed = new UserEmail(userEmail);
+
+        // when
+        boolean isExist = userRepository.existsByEmail(userEmailEmbed);
+
+        // then
+        assertThat(isExist).isTrue();
+    }
+
+    @Test
+    void findByEmail() {
+        String userEmail = "[email protected]";
+        User user = User.builder()
+                .id(1L)
+                .userToken("userToken")
+                .email(userEmail)
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+        userRepository.save(user);
+
+        // when
+        User savedUser = userRepository.findByEmail(userEmail);
+
+        // then
+        assertThat(savedUser).isNotNull();
+    }
+
+    @Test
+    void findAllByUserToken() {
+        String userToken = "usr_token";
+        String userToken2 = "usr_token2";
+        User user = User.builder()
+                .id(1L)
+                .userToken(userToken)
+                .email("[email protected]")
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+
+        User user2 = User.builder()
+                .id(2L)
+                .userToken(userToken2)
+                .email("[email protected]")
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+        userRepository.save(user);
+        userRepository.save(user2);
+
+        // when
+        List<User> users = userRepository.findAllByUserToken(List.of(userToken, userToken2));
+
+        // then
+        assertThat(users.size()).isEqualTo(2);
+    }
+
+    @Test
+    void findAllByUserId() {
+        Long userId = 1L;
+        Long userId2 = 2L;
+        User user = User.builder()
+                .id(userId)
+                .userToken("userToken")
+                .email("[email protected]")
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+
+        User user2 = User.builder()
+                .id(userId2)
+                .userToken("userToken2")
+                .email("[email protected]")
+                .password("password")
+                .major("major")
+                .name("name")
+                .passwordEncoder(passwordEncoder)
+                .build();
+        userRepository.save(user);
+        userRepository.save(user2);
+
+        // when
+        List<User> users = userRepository.findAllByUserId(List.of(userId, userId2));
+
+        // then
+        assertThat(users.size()).isEqualTo(2);
+    }
+
+
+
+}