Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscription): Stripeに顧客を新規作成する前にAPIに存在確認をするようにした #19

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

nafu-at
Copy link
Member

@nafu-at nafu-at commented Oct 20, 2024

ついでにログいっぱい増やした

What

Stripeに顧客を作成するエンドポイントを実行する前に、登録しようとしているメールアドレスが既にStripeに登録されていないか問い合わせるようにした。
これによりなぜか2回呼ばれることはなくなったはず。

Why

最初に作成した顧客がきちんと保存されていない状態でもう1回呼ばれた場合に2つ顧客が作成されてしまう上に、何らかのり

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

@u1-liquid u1-liquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nafu-at nafu-at merged commit 74e37b0 into TeamNijimiss:nijimiss Oct 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants