Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YouTube] Add support to extract total comment count #794

Merged
merged 8 commits into from
Jan 11, 2023
Merged

[YouTube] Add support to extract total comment count #794

merged 8 commits into from
Jan 11, 2023

Conversation

FireMasterK
Copy link
Member

@FireMasterK FireMasterK commented Feb 8, 2022 •
edited by AudricV
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Related issue: #793

@FireMasterK FireMasterK added the youtube service, https://www.youtube.com/ label Feb 8, 2022
@FireMasterK FireMasterK mentioned this pull request Feb 8, 2022
Closed
litetex
litetex reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements I found

.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Outdated Show resolved Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Outdated Show resolved Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Show resolved Hide resolved
@FireMasterK FireMasterK force-pushed the comments-count branch 2 times, most recently from 0616b5d to ad8659b Compare February 10, 2022 15:47
@prateekmedia
Copy link

Any progress?

@Stypox
Copy link
Member

Stypox commented Jul 13, 2022

@FireMasterK any update?

@FireMasterK
Copy link
Member Author

I'm currently a bit busy, I may be able to resume work on this the next or the week after.

@FireMasterK
Copy link
Member Author

Closing in favor of #936

@AudricV
Copy link
Member

AudricV commented Sep 29, 2022

This PR is about implementing replies count of a comment, while yours is about a different feature, the comments count of a stream!

Reopening.

@AudricV AudricV reopened this Sep 29, 2022
@Stypox Stypox mentioned this pull request Oct 31, 2022
Open
34 tasks
Stypox
Stypox requested changes Dec 31, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure is fine for me. @AudricV please merge this if you agree.

.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Outdated Show resolved Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Show resolved Hide resolved
@Stypox Stypox merged commit c1040bc into TeamNewPipe:dev Jan 11, 2023
@FireMasterK FireMasterK deleted the comments-count branch January 11, 2023 16:47
@TobiGr TobiGr mentioned this pull request Jan 17, 2023
Merged
3 tasks
@tsiflimagas tsiflimagas mentioned this pull request Aug 29, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex left review comments

@Stypox Stypox Stypox approved these changes

@AudricV AudricV Awaiting requested review from AudricV

Assignees
No one assigned
Labels
enhancement youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FireMasterK @prateekmedia @Stypox @AudricV @litetex