Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of media.ccc.de service #472

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix name of media.ccc.de service #472

merged 1 commit into from
Dec 2, 2020

Conversation

TheAssassin
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

(Well, arguably, the last point makes little sense, unless we also change the class names.)

This fixes the name of the service for https://media.ccc.de. Nobody other than NewPipe ever used the term "MediaCCC". I've seen some software around the site use "CCC-TV", but CCC themselves seem just to use the domain.

This is the least invasive method, as it merely changes the service's name string, which is then rendered in the app.

I am open to changing all the class names, but it'll be hard to find a new naming scheme. MediaCccDe might work, though.

@TobiGr TobiGr merged commit 8ade913 into dev Dec 2, 2020
@TheAssassin TheAssassin deleted the fix-media-ccc-de branch December 2, 2020 21:27
TobiGr added a commit to TeamNewPipe/NewPipe that referenced this pull request Dec 23, 2020
TobiGr added a commit to TeamNewPipe/NewPipe that referenced this pull request Dec 23, 2020
TobiGr added a commit to TeamNewPipe/NewPipe that referenced this pull request Dec 23, 2020
spvkgn pushed a commit to spvkgn/NewPipe that referenced this pull request Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants