Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for non-api mediaccc links, invidious shortened links, refactor mediaccc tests #256

Merged
merged 5 commits into from
Mar 15, 2020
Merged

Support for non-api mediaccc links, invidious shortened links, refactor mediaccc tests #256

merged 5 commits into from
Mar 15, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Feb 12, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

See TeamNewPipe/NewPipe#3090

@B0pol B0pol changed the title Mediaccc Support for non-api mediaccc links, invidious shortened links, refactor mediaccc tests Feb 12, 2020
@B0pol B0pol mentioned this pull request Feb 12, 2020
Merged
1 task
TobiGr
TobiGr reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Had a quick look, will review in more detail later if no one else does it.

...i/newpipe/extractor/services/media_ccc/linkHandler/MediaCCCConferenceLinkHandlerFactory.java Outdated Show resolved Hide resolved
...chabi/newpipe/extractor/services/media_ccc/linkHandler/MediaCCCStreamLinkHandlerFactory.java Outdated Show resolved Hide resolved
@TobiGr TobiGr added media.ccc.de service, https://media.ccc.de youtube service, https://www.youtube.com/ labels Feb 12, 2020
@B0pol B0pol requested a review from Stypox March 2, 2020 21:52
@Stypox Stypox self-assigned this Mar 3, 2020
@B0pol B0pol requested a review from Stypox March 13, 2020 19:08
wb9688
wb9688 approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@wb9688 wb9688 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@TobiGr: I can't merge it, is that due to the Travis CI failing?

@TobiGr
Copy link
Contributor

TobiGr commented Mar 15, 2020

@wb9688 yes

@TobiGr TobiGr merged commit 65a7eda into TeamNewPipe:dev Mar 15, 2020
@B0pol B0pol deleted the mediaccc branch March 15, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr left review comments

@wb9688 wb9688 wb9688 approved these changes

@Stypox Stypox Stypox approved these changes

Assignees

@Stypox Stypox

Labels
media.ccc.de service, https://media.ccc.de youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@B0pol @TobiGr @Stypox @wb9688