Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new URL encode/decode methods introduced in Java 10 #1196

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Use the new URL encode/decode methods introduced in Java 10 #1196

merged 2 commits into from
Jul 21, 2024

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 18, 2024 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Update the Utils encode/decode methods to call the new URL encode/decode methods introduced in Java 10. These methods do not require UnsupportedEncodingException to be caught.

@opusforlife2
Copy link
Collaborator

This refactor deal is right up your alley, isn't it? xD You've been submitting optimisations since the very beginning.

@AudricV AudricV added enhancement codequality Improvements to the codebase to improve the code quality labels Jul 18, 2024
@Isira-Seneviratne
Copy link
Member Author

This refactor deal is right up your alley, isn't it? xD You've been submitting optimisations since the very beginning.

Haha, yeah 😂

@TobiGr
Copy link
Member

TobiGr commented Jul 20, 2024

AH wait, are those Constants finally desugared correctly?

@Isira-Seneviratne
Copy link
Member Author

AH wait, are those Constants finally desugared correctly?

Yes: https://developer.android.com/studio/write/java11-nio-support-table

@Isira-Seneviratne Isira-Seneviratne mentioned this pull request Jul 21, 2024
Open
5 tasks
@Isira-Seneviratne Isira-Seneviratne merged commit 9a29f9e into TeamNewPipe:dev Jul 21, 2024
3 of 4 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Java-10-URL branch July 21, 2024 14:15
evermind-zz added a commit to bravenewpipe/NewPipeExtractor that referenced this pull request Jul 25, 2024
@evermind-zz
RUMBLE/BITCHUTE adjust to 'Use the new URL encode/decode methods intr…
c5f6d24 
…oduced in Java 10 (TeamNewPipe#1196)' commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Isira-Seneviratne @opusforlife2 @TobiGr @AudricV