[YouTube] Support shows and page header on user channels #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runs object was computed twice in getTextFromObject and getUrlFromObject methods, leading to unneeded search costs. This has been avoided by storing the array in method variables.
…lHelper This code will be used by YoutubeChannelTabExtractor to return whether the channel is verified in the corresponding property of all InfoItems from this channel. Also throw an exception when we cannot get the verified status of a channel in YoutubeChannelExtractor due to a missing channelHeader, if the channel has no channelAgeGateRenderer.
As there are multiple show UI elements which share a lot of common data, a base implementation, an abstract class named YoutubeBaseShowInfoItemExtractor, has been created to handle common cases.
Also fix naming of info items' collection methods.
…hannels Also move duplicate strings into constants and support pageHeader channel header in user channels on YoutubeChannelHelper methods.
Also move duplicate strings into constants and add a missing default switch case.
…s' content Gaming topic channels do not upload any content, all the content is coming from other channels. Also, uploader name, URL and verified status come are now got as much as possible from items instead of the channel info.
|
Sorry, had to open #1170 because I couldn't push to AudricV's repo |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full credits to @AudricV