Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor extractor #11

Merged
merged 1 commit into from
Jul 9, 2017
Merged

Refactor extractor #11

merged 1 commit into from
Jul 9, 2017

Conversation

mauriciocolli
Copy link
Contributor

  • Create some abstract classes to minimize repeated code
    • Extractor and Info
  • Channel and Playlist extractors have a getNextStreams method now
  • Organize some packages and classes
    • Rename package stream_info to just stream
  • Refactor and fix indentation in general

Closes #6

@theScrabi
Copy link
Member

Can you please send a coresponding pull request for NewPipe itself. NewPipe is not yet able to handle the refactored code.

@mauriciocolli
Copy link
Contributor Author

I'm not finished in the NewPipe side (maybe this weekend), but you can already merge it, just let the submodule in NewPipe pointing to the latest commit until now (ab53038), but it's up to you to decide...

@mauriciocolli mauriciocolli force-pushed the refactor-extractor branch 2 times, most recently from 3211dfd to 654e0c8 Compare June 29, 2017 18:12
@mauriciocolli
Refactor extractor
21e542e 
- Refactor info classes and extractors
- Reformat and fix indentation
- Organize packages and classes
- Rename variables/methods and fix regex
- Change the capitalization
- Add methods to playlist extractor
@mauriciocolli mauriciocolli mentioned this pull request Jul 9, 2017
Closed
@theScrabi
Copy link
Member

@mauriciocolli all right please merge :)

@mauriciocolli mauriciocolli merged commit 7299308 into TeamNewPipe:master Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauriciocolli @theScrabi