Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProGuard rules to README #1080

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Add ProGuard rules to README #1080

merged 1 commit into from
Jul 7, 2023

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Jul 4, 2023

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Closes #1048

@TobiGr TobiGr added the meta Related to the project but not strictly to code label Jul 4, 2023
AudricV
AudricV requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, I think you may also want to update the License paragraph to refer to NewPipe Extractor instead of NewPipe, which needs to be done in some files too like stated in an issue.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TobiGr TobiGr merged commit 986a3f7 into dev Jul 7, 2023
@opusforlife2 opusforlife2 deleted the proguard-rules branch July 7, 2023 18:56
This was referenced Jul 31, 2023
Merged
Closed
@AudricV AudricV changed the title Add proguard rules to README Add ProGuard rules to README Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudricV AudricV AudricV approved these changes

Assignees
No one assigned
Labels
meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how should I configure the proguard-rule?
2 participants
@TobiGr @AudricV