Fix signature extraction parse exception #108
Conversation
|
Looks OK to me. Can we release soon after this is merged? (And can F-Droid please be fast for once? ) |
|
Yeah, we should release ASAP. Though the solution is probably temporary and can be easily patched. We might need to find a better way to match this soon. |
| Parser.matchGroup("([\"\\'])signature\\1\\s*,\\s*([a-zA-Z0-9$]+)\\(", playerCode, 2); | ||
| decryptionFuncName = Parser.matchGroup( | ||
| // Look for a function with the first line containing pattern of: [var]=[var].split("") | ||
| "(\\w+)\\s*=\\s*function\\((\\w+)\\)\\{\\s*\\2=\\s*\\2\\.split\\(\"\"\\)\\s*;", |
There was a problem hiding this comment.
Is this the solution form youtube-dl?
There was a problem hiding this comment.
It's from a PR, which is not merged yet.
|
After extractor failed to decrypt a stream I went on NewPipe git and found this PR and patched local extractor lib. That's insane that you don't have normal embed player one year later:) |
|
Hi @karyogamy, youtube-dl has now merged another regex pattern which works as well. Thought you would be interested to know. It can be found in their latest release or alternatively here. |
|
@The-Demon-Prosecutor Thanks, I've created a new PR with the update. See #109. |
Copy of fix PR on youtube-dl because of I'm too dumb to figure out a solution and decided to wait it out =P
The stream extraction tests are now passing.
Credits and many thanks to @Khang-NT.