Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Fix YouTube Music client version extraction from HTML page #1051

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

Theta-Dev
Copy link
Contributor

I noticed that the code to extract the YouTube Music client version is missing the regex capture group index.

Since the bug is present in the second fallback option, it probably never caused any issues.

I have tested the fix by commenting out the 2 alternative options.

@TobiGr TobiGr added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Apr 16, 2023
@TobiGr TobiGr merged commit b2b4260 into TeamNewPipe:dev Apr 16, 2023
@Theta-Dev Theta-Dev deleted the fix/ytm-client-version-rg branch April 21, 2023 17:27
@AudricV AudricV changed the title [YouTube] fix: set musicClientVersion regex capture group [YouTube] Fix YouTube Music client version extraction from HTML page May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants