Avoid player jumping on devices with a cutout and fix two taps required for interacting

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Restore the code to prevent the player jumping on devices with a cutout.

Fixes the following issue(s)

• Fixes immersive fullscreen is gone #9799
• Fixes Interaction needs one tap before beeing able to interact #9773

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[opusforlife2]

I was about to mention this problem. If you're in landscape full screen, and you try to swipe up on the Full Screen button to scroll down the video details page, the player just starts jumping and preventing the gesture from working. Hopefully this fixes it.

[Stypox]

@SameenAhnaf could you check if this also fixes your "requires two taps" problem?

[SameenAhnaf]

@Stypox Nope, this PR doesn't fix that bug

[Stypox]

@Isira-Seneviratne then I think it's best to just revert #8894. It required to fix many bugs before merging, and even after merging new bugs keep arising. I don't think it's worth it to use WindowCompat if it just causes bugs. I opened #9812.

[Stypox]

Actually, I found out all flags were deprecated, so let's try a bit more before reverting. I pushed a commit that properly sets window flags only when needed, and also does not use BEHAVIOR_SHOW_BARS_BY_TOUCH which is deprecated on Android 12+.

[Isira-Seneviratne]

@Stypox I simplified one of the methods you added.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[Stypox]

Since this still does not solve #9773, I will merge #9812 instead, sorry. Let's not forget about the code in this PR as it might come in handy