Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening links on Android 12+ #9758

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Feb 7, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

#9726 wasn't enough. Android 12+ seems to return null to calls to resolveActivity, so the previous code would have said "No app can open this". Now instead, we try to open the activity in any case, even when we don't have a resolved package to set. I will take care of removing the now unused string if this PR is considered correct.
@AudricV do you think this is ok?

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Stypox Stypox added bug Issue is related to a bug ASAP Issue needs to be fixed as soon as possible device/software specific Issues that only happen on some devices or with some specific hardware/software labels Feb 7, 2023
@TobiGr
Copy link
Member

TobiGr commented Feb 7, 2023

Is null returned on any Android version or just A12+? If the latter is the case, I'd suggest to implement the old behaviour for Android <= 11

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox
Copy link
Member Author

Stypox commented Feb 7, 2023

I thought about that, too. But what's the advantage of showing an error to the user instead of trying again in a different way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants