Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a setting to switch the sides of volume and brightness #9708

Merged
merged 14 commits into from
Apr 4, 2023

Conversation

Marius1501
Copy link
Contributor

@Marius1501 Marius1501 commented Jan 20, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Added a setting in Video and Audio settings under behavior
  • When you switch it on the sides of volume and brightness gesture are switched
  • The toggle is disabled if one of the gesture control toggles above is switched off

Before/After Screenshots/Screen Record

Normal Video and Audio settings When one toggle is switched off
Before After

Fixes the following issue(s)

Due diligence

@SameenAhnaf SameenAhnaf added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Jan 20, 2023
@Marius1501
Copy link
Contributor Author

I fixed a small bug. Now everything should be fine.

@Stypox
Copy link
Member

Stypox commented Jan 28, 2023

Mmmh, after thinking about it, I think it's better to have two list options ("Gesture for left side", "Gesture for right side"), a where each option allows choosing amongst "None", "Audio control", "Brightness control". This also means that the user will be able to use one half of the screen for volume, and leave the other half without any gesture, which may help in some situations. This design is also future-proof if we decide to add more possible gesture actions.

@Marius1501
Copy link
Contributor Author

Marius1501 commented Jan 29, 2023

grafik

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like "left/right gesture control" is not easy to understand. What about "Action for gesture on left/right side"?

@Stypox
Copy link
Member

Stypox commented Feb 7, 2023

Did you think of a better name&description for the setting?

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox Stypox force-pushed the switch_setting_brightness_volume branch from 00f7169 to d273560 Compare April 4, 2023 07:58
@Stypox Stypox force-pushed the switch_setting_brightness_volume branch from 40ba85d to 4bb45c0 Compare April 4, 2023 09:06
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed two commits to fix checkstyle and fix the settings migrations (the incorrect keys were used). I tested by importing my database in two different combinations of enabled gestures and the migration seemed to run nice.

Thank you!

@Stypox Stypox merged commit 445d364 into TeamNewPipe:dev Apr 4, 2023
@Marius1501 Marius1501 deleted the switch_setting_brightness_volume branch April 5, 2023 06:37
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring volume and brightness sides
4 participants