Orientation is locked if there is no sensor for it #9693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirion
added
GUI
TobiGr
added
the
player
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Jan 16, 2023
| return android.provider.Settings.System.getInt( | ||
| context.getContentResolver(), Settings.System.ACCELEROMETER_ROTATION, 0) == 0; | ||
| context.getContentResolver(), Settings.System.ACCELEROMETER_ROTATION, 0) == 0 |
There was a problem hiding this comment.
I wonder what the getInt returns when there is no accelerometer for rotation... Shouldn't it already return 0, as it's the default value passed for when the stored value is not valid?
There was a problem hiding this comment.
the setting exists in aosp. The manufacturer would have to deliberately remove the setting. So it most likely is there. And if not: all the guys with their realy odd hardware are happy, that the button is there for them
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This #4478 (comment) in the ever lasting full screen button discussion is actually valid. If a device does not feature an accelerometer (STB, Terminal, TV), the screen cannot rotate. It is more some sort of "sanity" check, as "def_accelerometer_rotation" in the SettingsProvider in AOSP is "false", which means, that after a factory reset, auto rotation of the screen should be disabled anyway. So a device manufacturer must have deliberately broken it (actually a device bug, not a bug in NewPipe) or a user must have selected screen auto rotation, even though it doesn't work. So this probably affects only a handful of users of NewPipe.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence