Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that prevented the display of multiple empty playlists #9642

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

Jared234
Copy link
Contributor

@Jared234 Jared234 commented Jan 8, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • The issue was fixed by changing the faulty query getPlaylistMetadata:
    If a playlist has no streams, there won’t be any rows in the PLAYLIST_STREAM_JOIN_TABLE table that have a foreign key to that playlist. Thus, the JOIN_PLAYLIST_ID will not have a corresponding value in any rows of the join table. So, if you group by the JOIN_PLAYLIST_ID, only playlists that contain videos are grouped and displayed.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added bug Issue is related to a bug playlist Anything to do with playlists in the app labels Jan 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I can confirm it works :-)

@Stypox Stypox merged commit e44d092 into TeamNewPipe:dev Jan 13, 2023
@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug playlist Anything to do with playlists in the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty playlist are not showed in playlist bookmarks when are more than one empty
3 participants