-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using background player when there are no separate audio streams #9562
Allow using background player when there are no separate audio streams #9562
Conversation
Some services may only have video streams and no separate audio streams available. This commit will add audio background playback support for those services. It uses the video source as audio source for background playback.
Yes Thanks, it works on Such YouTube Link with only 360p Video no separate audio. My NewPipe usecase mostly is for background listening & on above Link when i long press into background it spews following error on current dev of NewPipe Exception
Crash log
|
great so NewPipe has also a use case for this PR |
Note: I already made a fix for this bug in #8603. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Code looks good to me. I tested and this seems to work fine, by switching to background from the play queue on the video provided by @ShareASmile. However, on that video, the background button is still hidden in the video details fragment. Could you fix that, please?
@AudricV can this be merged even though #8603 also fixes the same issue? If you think it's better to just finish off #8603 then maybe we could do that and avoid some rebasing issues.
I'd rather wait for @AudricV to comment. AudricV's could best compare the different approaches. I think mine is more lower level meaning it is contained in AudioPlaybackResolver. transparently to upper layers. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested again, also taking a look at the network inspector, and it seems to work well. Thank you!
Some services may only have video streams and no separate audio streams available. This commit will add audio background playback support for those services. It uses the video source as audio source for background playback.
Note I think currently NewPipe is in no need to support this feature but maybe in the future. I use it in BraveNewPipe as some services do not support audio only streams. Would be great if it could be merged.
Thx
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence