Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when click "Add to playlist" while the current list is still loading #9521

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

pratyaksh1610
Copy link
Contributor

@pratyaksh1610 pratyaksh1610 commented Dec 9, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Crash fix on clicking on add to playlist.
  • Added toast when clicked on share button for better UI.

Before/After Screenshots/Screen Record

before.mp4
after.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

pratyaksh1610 and others added 2 commits December 9, 2022 14:09
- Crash fix on clicking on add to playlist.
- Added toast when clicked on share button for better UI.
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't think the toasts were needed, so I pushed a commit to remove them and also to allow sharing when the info is null.

@Stypox Stypox merged commit 6af2242 into TeamNewPipe:dev Dec 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pratyaksh1610 pratyaksh1610 deleted the branch-9518 branch January 1, 2023 16:50
@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
@AudricV AudricV changed the title Fixes #9518: Crash fix when click "Add to playlist" while the current list is still loading Fix crash when click "Add to playlist" while the current list is still loading Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when click "Add to playlist" while the current list is still loading
2 participants