Option to reset settings #9236

vincetzr · 2022-10-28T23:19:11Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Add a new setting: reset settings. This will delete the shared preference and restarts the app. An alert dialogue will appear to prevent accidental click.
Created new settings category: Backup and restore
Following settings have been move to the new category:
- import database (from ContenttSettings)
- export database (from ContenttSettings)
- reset settings (new)

Before/After Screenshots/Screen Record

Before	After	After video
		Screen.Recording.2022-10-29.at.10.04.33.am.mov

Fixes the following issue(s)

Fixes: Option to reset settings. #9036

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

TobiGr

Thank you for the PR.

Please remember to make new strings translatable.

There are no debug settings in the release APKs. Therefore, placing this action into the debug settings does not solve the problem or use case mentioned in the issue. We should find a better place for it. Unfortunately, I cannot think of a category that somehow works on this. IMO it's time to create a new settings category (Backup & Restore maybe?). It should contain the backup actions which are currently placed in history & cache.

@ All, what do you think on that suggestion?

app/src/main/java/org/schabi/newpipe/settings/DebugSettingsFragment.java

TobiGr · 2022-10-29T10:04:00Z

app/src/main/res/xml/debug_settings.xml

+    <Preference
+        android:key="@string/reset_settings"
+        android:title="@string/settings_category_reset_title"
+        app:iconSpaceReserved="false" />


We need to ensure that the title is fully displayed on small devices:

Suggested change

app:iconSpaceReserved="false" />

app:singleLineTitle="false"

app:iconSpaceReserved="false" />

I see. Thank you for pointing it out. I have committed the changes.

I see. Thank you for pointing it out. I have committed the changes.

I think you can start working on the solution TobiGr mentioned above. I will help you.

Since the deadline is passed and we have more assignments to do, also 4 final exams and a 2000-word essay are coming. We have to wait until 15 Nov or later to continue to work on this PR

Ok, don't worry, and good luck with exams! ;-)

I will turn this PR into a draft for now, feel free to write a comment once you get back on it, so that we see it

Understood. Thank you.

sonarcloud · 2022-10-29T19:18:47Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

ghost · 2023-02-28T07:51:05Z

You can already reset your settings by clearing your storage for the app.

EDIT:I forgot to mention it would also clear out all your history for the app! Sorry for the confusion 😞

TobiGr · 2023-09-17T15:30:00Z

Rebased
Created new settings category: Backup and restore
Following settings have been moved to the new category:
- import database (from ContenttSettings)
- export database (from ContenttSettings)
- reset settings (from DebugSettings)

TobiGr

LGTM
Please wait for approval by second maintainer regarding new settings structure

opusforlife2 · 2023-09-18T20:46:39Z

I would say let's have an extra precautionary step before the task is executed. The alert dialog should have a check box that needs to be checked before the Yes button can be tapped, until which it will remain greyed out.

TobiGr · 2023-09-18T20:59:03Z

Having one dialog with CANCEL and OK is the same flow used for clearing the watch and search history as well as the playback positions. I think it should be consistent with these similar actions.

opusforlife2 · 2023-09-18T21:10:09Z

Well, there should be a check box for those too. Any destructive action should have this double check. It's different from PC where you usually have to move the pointer quite a distance to execute the task. On Android, mis-taps are far more likely to occur. (e.g. just today I accidentally deleted an important SMS from its heads-up notification and had to request a re-send.)

Ensuring title to be fully displayed on small devices. Co-authored-by: Tobi <[email protected]>

Following settings have been move to the new category: - import database (from ContenttSettings) - export database (from ContenttSettings) - reset settings (from DebugSettings)

sonarcloud · 2023-09-21T14:11:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

sonarcloud · 2024-03-28T17:50:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Stypox

Thank you!

TobiGr requested changes Oct 29, 2022

View reviewed changes

peat80 mentioned this pull request Oct 29, 2022

Add import & export section in the settings menu #9226

Closed

6 tasks

TobiGr reviewed Oct 29, 2022

View reviewed changes

TobiGr added the feature request Issue is related to a feature in the app label Oct 29, 2022

Stypox marked this pull request as draft October 30, 2022 21:25

TobiGr force-pushed the Option-to-reset-settings branch from 6bc9581 to f231a35 Compare September 17, 2023 15:22

TobiGr marked this pull request as ready for review September 17, 2023 15:22

TobiGr approved these changes Sep 17, 2023

View reviewed changes

vincetzr and others added 16 commits September 21, 2023 16:01

Added reset button but not working as intended.

5d101e7

Added reset button but slightly working as intended.

aa18471

Added reset button but working as intended for theme.

58517d1

Cleaned up xml files.

2103a04

Added alert dialogue and restarts the app when resetting settings.

076e9ee

Changed alert dialogue.

5c46412

clear shared preference xmls

23de9bf

Added delete xml method inside the yes dialogue.

81ad50e

Revert changes made to dev.

06d2562

Revert changes made to dev.

a239a26

Revert changes made to dev.

25a7309

Revert committed file change of settings key.

40a3e1b

Added strings to strings.xml to allow translation.

d7ef9b1

Update app/src/main/res/xml/debug_settings.xml

ad0855a

Ensuring title to be fully displayed on small devices. Co-authored-by: Tobi <[email protected]>

Create new settings category: Backup and restore

f2e3528

Following settings have been move to the new category: - import database (from ContenttSettings) - export database (from ContenttSettings) - reset settings (from DebugSettings)

Remove strange change

ff1aca2

Add summary to reset preference

df2e0be

TobiGr force-pushed the Option-to-reset-settings branch from 8dd28a2 to df2e0be Compare September 21, 2023 14:01

Merge branch 'dev' into pr9236

37f7fa7

github-actions bot added the size/large PRs with less than 750 changed lines label Mar 28, 2024

Stypox approved these changes Mar 28, 2024

View reviewed changes

Stypox merged commit 2af95cc into TeamNewPipe:dev Mar 28, 2024
5 of 6 checks passed

Stypox mentioned this pull request Apr 1, 2024

Release v0.27.0 (please TEST!) #10930

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to reset settings #9236

Option to reset settings #9236

vincetzr commented Oct 28, 2022 •

edited by TobiGr

Loading

TobiGr left a comment

TobiGr Oct 29, 2022

vincetzr Oct 29, 2022 •

edited

Loading

plasticanu Oct 29, 2022 •

edited

Loading

plasticanu Oct 30, 2022

Stypox Oct 30, 2022 •

edited

Loading

vincetzr Oct 31, 2022

sonarcloud bot commented Oct 29, 2022

ghost commented Feb 28, 2023 •

edited by ghost

Loading

TobiGr commented Sep 17, 2023 •

edited

Loading

TobiGr left a comment

opusforlife2 commented Sep 18, 2023

TobiGr commented Sep 18, 2023

opusforlife2 commented Sep 18, 2023

sonarcloud bot commented Sep 21, 2023

sonarcloud bot commented Mar 28, 2024

Stypox left a comment

	app:iconSpaceReserved="false" />
	app:singleLineTitle="false"
	app:iconSpaceReserved="false" />

Option to reset settings #9236

Option to reset settings #9236

Conversation

vincetzr commented Oct 28, 2022 • edited by TobiGr Loading

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

Due diligence

TobiGr left a comment

Choose a reason for hiding this comment

TobiGr Oct 29, 2022

Choose a reason for hiding this comment

vincetzr Oct 29, 2022 • edited Loading

Choose a reason for hiding this comment

plasticanu Oct 29, 2022 • edited Loading

Choose a reason for hiding this comment

plasticanu Oct 30, 2022

Choose a reason for hiding this comment

Stypox Oct 30, 2022 • edited Loading

Choose a reason for hiding this comment

vincetzr Oct 31, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Oct 29, 2022

ghost commented Feb 28, 2023 • edited by ghost Loading

TobiGr commented Sep 17, 2023 • edited Loading

TobiGr left a comment

Choose a reason for hiding this comment

opusforlife2 commented Sep 18, 2023

TobiGr commented Sep 18, 2023

opusforlife2 commented Sep 18, 2023

sonarcloud bot commented Sep 21, 2023

sonarcloud bot commented Mar 28, 2024

Quality Gate passed

Stypox left a comment

Choose a reason for hiding this comment

vincetzr commented Oct 28, 2022 •

edited by TobiGr

Loading

vincetzr Oct 29, 2022 •

edited

Loading

plasticanu Oct 29, 2022 •

edited

Loading

Stypox Oct 30, 2022 •

edited

Loading

ghost commented Feb 28, 2023 •

edited by ghost

Loading

TobiGr commented Sep 17, 2023 •

edited

Loading