Show correct tooltips for actions in feed #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR shows the correct
tooltips for hide/show actions in the feed. So when watched/future items are shown, the tooltip is "Hide watched/future items", otherwise it is "Show watched/future items". This is because the tooltip should represent the action performed by clicking on the button, as requested here. The item'stitles, though, should just be a description of the button, and so stay the same (always "Show ... items"). This PR also changes "Show/hide future videos" to "Show/hide future items", in order to be consistent with "Show/hide watched videos", and also because a user's feed may not be composed of only videos.While testing I noticed that, when pressing the buttons, sometimes the future-items tooltip wouldn't be updated right away, while the watched-items would. I don't know why this is, since the code for updating the two is exactly the same. Anyway, the tooltip set when the button is first shown is correct, and the tooltip also becomes correct after a while or after the menu gets reloaded. Maybe this problem has to do with some caching done by the system? Idk, but I wouldn't spend too much time on this anyway.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence