Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some accessibility issues in the GUIs #8960

Closed
wants to merge 1 commit into from

Conversation

dhruvpatidar359
Copy link
Contributor

@dhruvpatidar359 dhruvpatidar359 commented Sep 11, 2022

Signed-off-by: dhruv [email protected]
feed_group_card_item.xml button spacing has been changed.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR increases the Spacing between the channel groups so that visually impared people can easly interact with it . For that the margin has been changed

  • record videos
  • create clones
  • take over the world

Before/After Screenshots/Screen Record

  • Before:

ba8c88f1-0c1c-4471-8c4a-b956cc1d6c25

  • After:

f313543d-af01-4952-9bb0-0fa5edf871d2

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

feed_group_card_item.xml button spacing has been changed.
@MD77MD
Copy link

MD77MD commented Sep 18, 2022

is it possible to make group show in a customizable grid view something like 5x5

@dhruvpatidar359
Copy link
Contributor Author

is it possible to make group show in a customizable grid view something like 5x5
ok , i will work on it

@TobiGr TobiGr added the GUI Issue is related to the graphical user interface label Oct 9, 2022
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Oct 28, 2022

Closing in favor of #9207. Thanks for your effort.

@dhruvpatidar359 dhruvpatidar359 deleted the Ui-change branch October 29, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some accessibility issues in the GUIs
4 participants