Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.24.0 (990) #8889

Merged
merged 214 commits into from
Sep 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
214 commits
Select commit Hold shift + click to select a range
24cf197
Clean up proguard file
TacoTheDank Jun 9, 2022
bd19013
Updated extractor to latest revision
litetex Jun 21, 2022
04e8e03
Fix compile errors
litetex Jun 21, 2022
ad97b3d
Use correct ``NonNull``
litetex Jun 22, 2022
f22417e
Add option to hide future videos in feed
carmebar Jun 24, 2022
d5985be
Made some much needed changes to the ReadMe (#8372)
opusforlife2 Jun 25, 2022
1404581
Update ExoPlayer to 2.18.0
TacoTheDank Jun 26, 2022
45d2492
Run CI on all release branches (#8565)
Stypox Jul 1, 2022
00b9c08
Set setUsePlatformDiagnostics to false
TacoTheDank Jul 2, 2022
a1f1acf
Use minimum required permissions for GitHub workflows
triallax Jul 3, 2022
47a2adc
Make thumbnails' scaleType fitCenter
Stypox Jul 4, 2022
70b20f9
Align playlist thumbnail to left for more visibility
Stypox Jul 4, 2022
81369d7
Merge pull request #8531 from litetex/fix-extractor-compile-errors-846
Stypox Jul 4, 2022
d81607c
Merge branch 'master' into dev
Stypox Jul 5, 2022
8d26d9d
Translated using Weblate (Greek)
weblate Jul 5, 2022
4fd8294
Fix lang code 1/2: remove localization zh-rCN
chr56 Jun 25, 2022
d033a6e
Fix lang code 2/2: rename b+zh+HANS+CN to zh-rCN
chr56 Jun 25, 2022
acc34cb
Merge pull request #8549 from chr56/langcode_zh-rCN
Stypox Jul 5, 2022
0e55803
Merge pull request #8468 from TacoTheDank/cleanProguard
Stypox Jul 6, 2022
a4724fe
Add download option to long-press menu
May 13, 2022
d9af788
Merge pull request #8397 from notaLonelyDay/add-download-to-longpress…
Stypox Jul 6, 2022
a392a06
Fix feed menu items order in category to leave space for search
Stypox Jul 13, 2022
b96c8a0
Merge pull request #8545 from carmebar/hide-future-videos
Stypox Jul 13, 2022
93b913e
Merge pull request #8536 from TacoTheDank/bumpExoPlayer
Redirion Jul 13, 2022
d0b6d95
Add Share option to local playlists
carmebar Jun 24, 2022
6f7298b
Crop the notification thumbnail in 1:1 mode instead of stretching it …
OxygenCobalt Jul 13, 2022
f7d8781
Specify used ExoPlayer libraries (#8469)
TacoTheDank Jul 13, 2022
d5599eb
Merge pull request #8573 from Stypox/better-thumbnails
Stypox Jul 13, 2022
0b644fd
Merge pull request #8569 from mhmdanas/add-workflow-permissions
Stypox Jul 13, 2022
e55e79b
Bump minSdk to 21 (Android 5 / Lollipop)
litetex Jul 6, 2022
7cb137a
Remove MultiDex
litetex Jul 6, 2022
99104fc
Clean up pre-Lollipop checks
litetex Jul 6, 2022
b125780
Clean up pre-Lollipop compat attributes
litetex Jul 6, 2022
9648525
Clean up pre-Lollipop theming
litetex Jul 6, 2022
4ec9cbe
Remove AndroidX Webkit
TacoTheDank Jul 6, 2022
189c92a
More minSdk 21 cleanup
TacoTheDank Jul 6, 2022
bc37312
Merge pull request #7613 from litetex/increase-minsdk
Stypox Jul 13, 2022
76ced59
Refactor player: separate UIs and more
Stypox Apr 8, 2022
b3f9964
Fix some crashes / issues after player refactor
Stypox Apr 9, 2022
0bba1d9
Move all notification-related calls to NotificationPlayerUi
Stypox Apr 14, 2022
90a89f8
Move player-notification files into their package
Stypox Apr 14, 2022
8c26403
Remove unused PlayerState
Stypox Apr 14, 2022
6fb0256
Remove unused PlayerServiceBinder
Stypox Apr 14, 2022
fa25ecf
Add comment about broadcast receiver
Stypox Apr 14, 2022
6559416
Improve //region comments in player UIs
Stypox Apr 14, 2022
1b39b53
Add some javadocs; move preparing player uis to PlayerUiList
Stypox Apr 14, 2022
a19073e
Restore checkstyle and solve its errors
Stypox Apr 16, 2022
4979f84
Solve some Sonarlint warnings
Stypox Apr 16, 2022
1cf746f
Fix volume gestures not working anymore
Stypox Jul 7, 2022
9c51fc3
Move functions to get Android dimen to ThemeHelper
Stypox Jul 7, 2022
3692858
Move popup layout param to PopupPlayerUi
Stypox Jul 8, 2022
61c1da1
Some refactorings after review comments
Stypox Jul 9, 2022
c03eac1
Some SonarLint refactors
Stypox Jul 9, 2022
4443c90
Fix SonarLint java:S5320, restrict broadcasts to app package
Stypox Jul 9, 2022
8187a3b
Move PlayerType into its own class and add documentation
Stypox Jul 10, 2022
70e3c98
Merge pull request #8542 from carmebar/share-playlist
Stypox Jul 13, 2022
4536e8b
Update some miscellaneous libraries
TacoTheDank Jul 14, 2022
c1e78cf
Update OkHttp to 4.x
TacoTheDank Jul 14, 2022
cc7a8fb
Improve image placeholders
krlvm Jun 21, 2022
7b41acb
Use corresponding material icon in user profile thumbnail
krlvm Jul 7, 2022
429f253
Optimize thumbnail placeholder drawables
krlvm Jul 7, 2022
35eeccd
Rename buddy.xml to dummy_person.xml
krlvm Jul 13, 2022
dff1adb
Fix swapped colors in video and playlist thumbnails
krlvm Jul 13, 2022
7b9b921
Remove bottom-sheet-thumbnail placeholder, clear the image instead
Stypox Jul 14, 2022
4d58026
Improve placeholder thumbnail SVGs and remove theme customization
Stypox Jul 14, 2022
6ea85e6
Rename dummy_* and more to placeholder_*
Stypox Jul 14, 2022
9f993e0
Make video and playlist placeholder thumbnails 16:9
Stypox Jul 14, 2022
33e2076
Merge pull request #8530 from krlvm/improve_placeholder_images
Stypox Jul 14, 2022
0e8cc72
Fix random NullPointerException when adding video player view
Stypox Jul 14, 2022
b7a4456
Merge pull request #8170 from Stypox/player-refactor
litetex Jul 15, 2022
25a43b5
Updated checkstyle
litetex Jul 10, 2022
8b209df
Changed the code accordingly
litetex Jul 10, 2022
3890d0a
Added note that explains that unused code was removed.
litetex Jul 15, 2022
3ba04f1
Fixed conflicts/build
litetex Jul 15, 2022
5da8d5f
Use ViewCompat.setBackgroundTintList().
Isira-Seneviratne Jul 16, 2022
f1de353
Use stream sorting.
Isira-Seneviratne Jul 16, 2022
a1c6f00
Rename "waiting-for-author" label to "waiting for author" (#8642)
triallax Jul 17, 2022
d9ff114
Merge pull request #8601 from litetex/checkstyle-assign-on-same-line
Stypox Jul 18, 2022
cd14096
Merge pull request #8633 from Isira-Seneviratne/Use_ViewCompat_setBac…
Stypox Jul 18, 2022
e8669d4
Deduplicate SQL queries to get feed streams
Stypox Jul 13, 2022
ae369ec
Merge pull request #8475 from TacoTheDank/bumpMiscLibraries
Stypox Jul 18, 2022
e772244
Update app/src/main/java/org/schabi/newpipe/fragments/detail/Descript…
Isira-Seneviratne Jul 18, 2022
c53143e
Use Set.of().
Isira-Seneviratne Jul 15, 2022
4eddd2c
Fix random NullPointerException when adding video player view
Stypox Jul 19, 2022
ca26fcb
Use List.of().
Isira-Seneviratne Jul 15, 2022
55a995c
Replace LinkedHashMap with List.of().
Isira-Seneviratne Jul 15, 2022
a6cc138
Use Map.of().
Isira-Seneviratne Jul 19, 2022
d62cdc6
Use MathUtils.clamp().
Isira-Seneviratne Jul 18, 2022
394eb92
Use coerceIn().
Isira-Seneviratne Jul 18, 2022
1594716
Merge pull request #8635 from Isira-Seneviratne/Use_stream_sort
Stypox Jul 20, 2022
c5b970c
Improve code style in List.of()
Stypox Jul 20, 2022
344c33d
Merge pull request #8631 from Isira-Seneviratne/Use_collection_factories
Stypox Jul 20, 2022
373ee53
Improve code style
Stypox Jul 20, 2022
cacce6d
Merge pull request #8651 from Isira-Seneviratne/Use_limiting_methods
Stypox Jul 20, 2022
b845645
Use IO extensions.
Isira-Seneviratne Jul 18, 2022
8b400b4
Refactor notifying method in PlayQueue.
Isira-Seneviratne Jul 19, 2022
6d1c614
Remove unnecessary method in ChannelFragment.
Isira-Seneviratne Jul 20, 2022
f1dab11
Remove deprecated method calls in FocusAwareCoordinator.
Isira-Seneviratne Jul 21, 2022
37275e8
Fix wrong thumbnail used as placeholder for channel
Stypox Jul 22, 2022
f4fe5fc
Fix ListHelperTest failure caused by immutable list being used
Stypox Jul 22, 2022
abf185c
Merge pull request #8679 from Stypox/fix-listhelpertest
Stypox Jul 22, 2022
b2c2570
Merge pull request #8676 from Stypox/fix-channel-placeholders
Stypox Jul 22, 2022
3281ed2
Merge pull request #8648 from Isira-Seneviratne/Use_IO_extensions
Stypox Jul 22, 2022
bfaf074
Merge pull request #8663 from Isira-Seneviratne/Remove_unnecessary_me…
Stypox Jul 23, 2022
74df7fc
Merge pull request #8670 from Isira-Seneviratne/Update_FocusAwareCoor…
Stypox Jul 23, 2022
8f37015
Merge pull request #8621 from Stypox/deduplicate-feed
litetex Jul 24, 2022
51e72d1
Removed the "(beta)"-tag from services (#8637)
litetex Jul 24, 2022
dcb332e
Merge pull request #8624 from TacoTheDank/bumpOkhttp
litetex Jul 24, 2022
8f5d564
Migrate NoNonsense-FilePicker to our updated fork
TacoTheDank Jul 21, 2022
baabba1
Disable Jetifier
TacoTheDank Jul 21, 2022
229422b
Update ExoPlayer to 2.18.1
TacoTheDank Jul 24, 2022
d7a654f
Update AndroidX Fragment to 1.4.1
TacoTheDank Jul 24, 2022
d66997c
Update Google Material to 1.6.1
TacoTheDank Jul 24, 2022
81fb44c
Remove uses of setBottomSheetCallback().
Isira-Seneviratne Jul 21, 2022
81c4b82
Add "needs triage" label to issue templates (#8643)
triallax Jul 26, 2022
af9c2bd
Use stackTraceToString().
Isira-Seneviratne Jul 27, 2022
6994200
Sort tags case-insensitively.
Isira-Seneviratne Jul 29, 2022
630558e
Use nested functions.
Isira-Seneviratne Jul 29, 2022
4d7a6fb
Use WindowMetrics API in VideoDetailFragment and PopupPlayerUi.
Isira-Seneviratne Jul 18, 2022
5c68c8e
Update Lifecycle to 2.5.1.
Isira-Seneviratne Jul 23, 2022
404c13d
Improve FeedViewModel factory
Stypox Jul 26, 2022
311d392
Use Application instead of Context in FeedViewModel.
Isira-Seneviratne Jul 31, 2022
582032f
Update AndroidX Room to 2.4.3
TacoTheDank Jul 31, 2022
35a118a
Merge pull request #8683 from Isira-Seneviratne/Update_Lifecycle
Stypox Jul 31, 2022
47f5804
Make OnClickGesture an interface.
Isira-Seneviratne Jul 31, 2022
8a89611
Apply code review change.
Isira-Seneviratne Aug 1, 2022
947242d
Update AppCompat to 1.4.2.
Isira-Seneviratne Jul 16, 2022
013522c
Convert LicenseFragmentHelper methods to top-level declarations.
Isira-Seneviratne Jul 22, 2022
a9095ca
Make block parameter an extension lambda.
Isira-Seneviratne Jul 23, 2022
ee36845
Merge pull request #8687 from TacoTheDank/bumpExoPlayer
Stypox Aug 2, 2022
ad30eb8
Merge branch 'dev' into bumpFragment
Stypox Aug 2, 2022
56cbf37
Merge pull request #8691 from TacoTheDank/bumpFragment
Stypox Aug 2, 2022
a548b34
Merge pull request #8692 from TacoTheDank/bumpMaterial
Stypox Aug 2, 2022
3420faa
Merge pull request #8661 from Stypox/player-refactor-npe
Stypox Aug 2, 2022
5c4874b
Merge pull request #8701 from Isira-Seneviratne/Use_stackTraceToString
Stypox Aug 3, 2022
368c6c0
Merge pull request #8709 from Isira-Seneviratne/Tags_case_insensitive
Stypox Aug 3, 2022
8a774dc
Merge pull request #8667 from Isira-Seneviratne/Update_AppCompat
Stypox Aug 3, 2022
7f018b9
Merge branch 'dev' into OnClickGesture_interface
Isira-Seneviratne Aug 4, 2022
ffc1d9a
Merge pull request #8656 from Isira-Seneviratne/Use_WindowMetrics
Stypox Aug 4, 2022
7972678
Merge branch 'dev' into bumpRoom
Stypox Aug 4, 2022
22d75f3
Merge pull request #8716 from TacoTheDank/bumpRoom
Stypox Aug 4, 2022
24ec642
Merge pull request #8669 from Isira-Seneviratne/Remove_setBottomSheet…
Stypox Aug 4, 2022
4b7de86
Clean up getLicenseStylesheet().
Isira-Seneviratne Jul 23, 2022
5640365
Merge pull request #8682 from Isira-Seneviratne/Refactor_LicenseFragm…
Stypox Aug 4, 2022
1a8f396
Merge pull request #8721 from Isira-Seneviratne/OnClickGesture_interface
Stypox Aug 4, 2022
059cfcb
Use Comparator factory methods in ListHelper.
Isira-Seneviratne Aug 2, 2022
d1f3f15
Use Comparator.comparingDouble().
Isira-Seneviratne Aug 3, 2022
8024b43
Add reusable classes extending AnimatorListenerAdapter.
Isira-Seneviratne Jul 29, 2022
2eec2e9
Replace coerceIn() with MathUtils.clamp().
Isira-Seneviratne Aug 5, 2022
fc46233
Use toArray() with zero-length arrays.
Isira-Seneviratne Jul 29, 2022
a9af1df
Applied code review changes.
Isira-Seneviratne Aug 5, 2022
ee6a279
Remove unused methods in HistoryRecordManager.
Isira-Seneviratne Aug 5, 2022
7aacaf8
Use Collectors.joining().
Isira-Seneviratne Jul 29, 2022
5c7dfd1
Remove unused method.
Isira-Seneviratne Jul 29, 2022
d9230c0
Merge pull request #8708 from Isira-Seneviratne/Reduce_View.kt_size
Stypox Aug 6, 2022
816154c
Merge pull request #8737 from Isira-Seneviratne/Fix_coerceIn
Stypox Aug 6, 2022
6f86e21
Merge pull request #8724 from Isira-Seneviratne/toArray_improvements
Stypox Aug 6, 2022
ebd06bd
Improve comment
Stypox Aug 6, 2022
80fb21e
Merge pull request #8728 from Isira-Seneviratne/Comparator_factory
Stypox Aug 6, 2022
edd2b11
Merge pull request #8738 from Isira-Seneviratne/Collectors_joining
Stypox Aug 6, 2022
74921d3
Merge pull request #8740 from Isira-Seneviratne/Cleanup_methods
Stypox Aug 6, 2022
0b11afa
Update Gradle to 7.5.1
TacoTheDank Aug 8, 2022
7f21f6e
Update AGP and clojars Maven URL
TacoTheDank Aug 9, 2022
2de33d8
Clarify that span shouldn't be in translated READMEs
triallax Aug 11, 2022
737a331
Remove extra whitespace from issue and PR templates
triallax Aug 11, 2022
571bf39
Merge pull request #8666 from TacoTheDank/filepicker
Stypox Aug 12, 2022
b9b09d3
Merge branch 'master' into dev
Stypox Aug 14, 2022
4f6b5b3
Use ListAdapter in PeertubeInstanceListFragment.
Isira-Seneviratne Jul 31, 2022
67669c2
Use ListAdapter in SuggestionListAdapter.
Isira-Seneviratne Jul 31, 2022
5e0788b
Use ListAdapter in PreferenceSearchAdapter.
Isira-Seneviratne Aug 1, 2022
2089f3e
Merge pull request #8719 from Isira-Seneviratne/Use_ListAdapter
TacoTheDank Aug 19, 2022
a50b9bd
Add FAQ entry to the template checklists (#8822)
opusforlife2 Aug 21, 2022
208dde6
Merge branch 'master' into dev
Stypox Aug 25, 2022
2e3e4f5
Merge pull request #8751 from TacoTheDank/bumpGradle
litetex Aug 25, 2022
679e81e
Merge pull request #8755 from mhmdanas/remove-whitespace
litetex Aug 25, 2022
1e964a3
Merge pull request #8754 from mhmdanas/clarify-that-span-shouldnt-be-…
litetex Aug 25, 2022
52dbfde
Keep strong references to Picasso notification icon loading targets
Stypox Jul 22, 2022
ce6f3ca
Merge pull request #8677 from Stypox/fix-picasso-target
litetex Aug 25, 2022
c054ea0
Create MediaSessionPlayerUi
Stypox Jul 21, 2022
bc33322
Remove useless MediaSessionCallback
Stypox Jul 21, 2022
3cc43e9
Fix thumbnail sometimes not set to media session metadata
Stypox Jul 21, 2022
f3a9b81
Fix sometimes seeing outdated thumbnail in notification
Stypox Jul 21, 2022
d73ca41
Even when thumbnails should not be shown, set it to null in notification
Stypox Jul 21, 2022
8bff445
Remove useless checks before updating metadata
Stypox Jul 22, 2022
f80d1dc
Let exoplayer decide when to update metadata
Stypox Jul 22, 2022
11bd236
Merge MediaSessionManager into MediaSessionPlayerUi
Stypox Jul 22, 2022
510efaa
Keep strong reference to Picasso thumbnail loading target
Stypox Jul 22, 2022
973a966
Review suggestions
Stypox Jul 26, 2022
59d1ded
Fixed sonar detected problems
litetex Aug 25, 2022
75917c7
Merge pull request #8678 from Stypox/media-session-ui
litetex Aug 25, 2022
6805c75
Fix surface view not resizing video correctly
Stypox Aug 2, 2022
500acce
Fix regression in screen rotation animation
Stypox Aug 24, 2022
ca0f56e
Avoid setting invalid states to bottom sheet callback
Stypox Aug 24, 2022
f9994ab
Prevent tapping on thumbnail if video details are not loaded
Stypox Aug 24, 2022
67b5de3
Translated using Weblate (Chinese (Simplified))
weblate Aug 27, 2022
131f78c
Merge pull request #8731 from Stypox/player-refactor-wrong-video-size
Stypox Aug 27, 2022
e7e61a0
Merge branch 'origin/dev' into Weblate.
weblate Aug 27, 2022
ebce4c5
Add changelog for v0.24.0 (990)
Stypox Aug 27, 2022
e6391a8
Release v0.24.0 (990)
Stypox Aug 27, 2022
7fbef35
Unify onThumbnailLoaded calls to ensure UIs always updated
Stypox Aug 28, 2022
4a7af6f
Remove thumbnail before sync, if outdated
Stypox Aug 28, 2022
f9109eb
Use player.getThumbnail() instead of field in VideoPlayerUi
Stypox Aug 28, 2022
ed87465
Only update notification large icon when it changes
Stypox Aug 28, 2022
051c572
Show correct tooltips for actions in feed
Stypox Sep 13, 2022
fbf5549
Fix wrong icons being set on suggestion items
Stypox Sep 14, 2022
1f57c87
Disable suggestion list animations: not meaningful
Stypox Sep 14, 2022
28b34f3
Fix scroll issues in suggestion list
Stypox Sep 14, 2022
ca29f6c
Merge pull request #8899 from Stypox/fix-player-thumbnail-handling
Stypox Sep 19, 2022
f26bf33
Merge pull request #8966 from Stypox/feed-menuitem-tooltip
Stypox Sep 19, 2022
bf55ed2
Merge pull request #8972 from Stypox/fix-suggestions-listadapter
Stypox Sep 19, 2022
8313f6b
Update NewPipeExtractor again
Stypox Sep 19, 2022
489f052
Fix feed menu tooltips (silly copy-paste error)
Stypox Sep 19, 2022
3110b08
Translated using Weblate (Tamil)
weblate Sep 25, 2022
aa9cd8c
Update NewPipeExtractor again
Stypox Sep 25, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 6 additions & 4 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Bug report
description: Create a bug report to help us improve
labels: [bug]
labels: [bug, needs triage]
body:
- type: markdown
attributes:
Expand All @@ -18,6 +18,8 @@ body:
required: true
- label: "I made sure that there are *no existing issues* - [open](https://github.com/TeamNewPipe/NewPipe/issues) or [closed](https://github.com/TeamNewPipe/NewPipe/issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to."
required: true
- label: "I have read the [FAQ](https://newpipe.net/FAQ/) and my problem isn't listed."
required: true
- label: "I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise."
required: true
- label: "This issue contains only one bug."
Expand All @@ -40,7 +42,7 @@ body:
label: Steps to reproduce the bug
description: |
What did you do for the bug to show up?

If you can't cause the bug to show up again reliably (and hence don't have a proper set of steps to give us), please still try to give as many details as possible on how you think you encountered the bug.
placeholder: |
1. Go to '...'
Expand Down Expand Up @@ -69,11 +71,11 @@ body:
label: Screenshots/Screen recordings
description: |
A picture or video is worth a thousand words.

If applicable, add screenshots or a screen recording to help explain your problem.
GitHub supports uploading them directly in the text box.
If your file is too big for Github to accept, try to compress it (ZIP-file) or feel free to paste a link to an image/video hoster here instead.

:heavy_exclamation_mark: DON'T POST SCREENSHOTS OF THE ERROR PAGE.
Instead, follow the instructions in the "Logs" section below.

Expand Down
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
name: Feature request
description: Suggest an idea for this project
labels: [enhancement]
labels: [enhancement, needs triage]
body:
- type: markdown
attributes:
value: |
Thank you for helping to make NewPipe better by suggesting a feature. :hugs:

Your ideas are highly welcome! The app is made for you, the users, after all.

- type: checkboxes
id: checklist
attributes:
label: "Checklist"
options:
- label: "I made sure that there are *no existing issues* - [open](https://github.com/TeamNewPipe/NewPipe/issues) or [closed](https://github.com/TeamNewPipe/NewPipe/issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to."
required: true
- label: "I have read the [FAQ](https://newpipe.net/FAQ/) and my problem isn't listed."
required: true
- label: "I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at [NewPipeExtractor](https://github.com/TeamNewPipe/NewPipeExtractor/issues)."
required: true
- label: "I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise."
Expand Down Expand Up @@ -43,7 +44,7 @@ body:
Describe any problem or limitation you come across while using the app which would be solved by this feature.
validations:
required: true

- type: textarea
id: additional-information
attributes:
Expand Down
6 changes: 4 additions & 2 deletions .github/ISSUE_TEMPLATE/question.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Question
description: Ask about anything NewPipe-related
labels: [question]
labels: [question, needs triage]
body:
- type: markdown
attributes:
Expand All @@ -16,6 +16,8 @@ body:
options:
- label: "I made sure that there are *no existing issues* - [open](https://github.com/TeamNewPipe/NewPipe/issues) or [closed](https://github.com/TeamNewPipe/NewPipe/issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to."
required: true
- label: "I have read the [FAQ](https://newpipe.net/FAQ/) and my question isn't listed."
required: true
- label: "I have taken the time to fill in all the required details. I understand that the question will be dismissed otherwise."
required: true
- label: "I have read and understood the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md)."
Expand All @@ -27,7 +29,7 @@ body:
label: What is/are your question(s)?
validations:
required: true

- type: textarea
id: additional-information
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<!-- Delete this if it doesn't apply to your PR. -->
-

#### APK testing
#### APK testing
<!-- Use a new, meaningfully named branch. The name is used as a suffix for the app ID to allow installing and testing multiple versions of NewPipe, e.g. "commentfix", if your PR implements a bugfix for comments. (No names like "patch-0" and "feature-1".) -->
<!-- Remove the following line if you directly link the APK created by the CI pipeline. Directly linking is preferred if you need to let users test.-->
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
branches:
- dev
- master
- release/**
- release**
paths-ignore:
- 'README.md'
- 'doc/**'
Expand All @@ -31,6 +31,10 @@ on:
jobs:
build-and-test-jvm:
runs-on: ubuntu-latest

permissions:
contents: read

steps:
- uses: actions/checkout@v3
- uses: gradle/wrapper-validation-action@v1
Expand Down Expand Up @@ -64,6 +68,10 @@ jobs:
matrix:
# api-level 19 is min sdk, but throws errors related to desugaring
api-level: [ 21, 29 ]

permissions:
contents: read

steps:
- uses: actions/checkout@v3

Expand All @@ -81,7 +89,7 @@ jobs:
# workaround to emulator bug: https://github.com/ReactiveCircus/android-emulator-runner/issues/160
emulator-build: 7425822
script: ./gradlew connectedCheck --stacktrace

- name: Upload test report when tests fail # because the printed out stacktrace (console) is too short, see also #7553
uses: actions/upload-artifact@v3
if: failure()
Expand All @@ -91,6 +99,10 @@ jobs:

sonar:
runs-on: ubuntu-latest

permissions:
contents: read

steps:
- uses: actions/checkout@v3
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/image-minimizer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
issues:
types: [opened, edited]

permissions:
issues: write
pull-requests: write

jobs:
try-minimize:
runs-on: ubuntu-latest
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/no-response.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
# Run daily at midnight.
- cron: '0 0 * * *'

permissions:
issues: write
pull-requests: write

jobs:
noResponse:
runs-on: ubuntu-latest
Expand All @@ -17,4 +21,4 @@ jobs:
with:
token: ${{ github.token }}
daysUntilClose: 14
responseRequiredLabel: waiting-for-author
responseRequiredLabel: waiting for author
Loading