Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use range-limiting methods in more places. #8747

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use range-limiting methods such as MathUtils.clamp() and Kotlin's coerceIn() in a couple more places.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Isira-Seneviratne Isira-Seneviratne marked this pull request as ready for review August 8, 2022 01:47
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Aug 8, 2022
@tsiflimagas
Copy link
Contributor

tsiflimagas commented Aug 9, 2022

Perhaps you could also handle the suggested solution of #8457, especially since that seems to have kinda stalled? Pardon me if it actually doesn't pertain to this PR, it seemed like it does.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ;-)

@Stypox Stypox merged commit 9524c62 into TeamNewPipe:dev Oct 28, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the Range_limit branch October 29, 2022 13:07
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants