Use Paging. #8718
Use Paging. #8718
Conversation
Isira-Seneviratne
force-pushed
the
Use_Paging
branch
from
282bab6 to
5e83456
Compare
|
This PR contains the commits from the Lifecycle PR. Could you fix this please? |
|
|
||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): SuggestionItemHolder { | ||
| TODO("Not yet implemented") | ||
| } |
There was a problem hiding this comment.
TODO detected, is there something to be done here?
Edit: I guess that's why it's a draft lol.
Isira-Seneviratne
force-pushed
the
Use_Paging
branch
2 times, most recently
from
1dbff2e to
b98b14a
Compare
|
Interesting! Since I don't know much about good practices for Android design, if you could provide some insight into how you did things I would be really glad :-) |
|
It seems like making use of the Paging library will require extensive changes to the extractor as well, since it assumes that the additional page items will be of the same type as the initial ones, while the extractor makes use of separate types for additional items. Retrofit could be useful there. A useful resource: https://developer.android.com/codelabs/android-paging @TacoTheDank @Stypox What do you think? Will the library be useful enough for these changes? |
Isira-Seneviratne
force-pushed
the
Use_Paging
branch
from
b98b14a to
ba477dc
Compare
|
I think each and every list present in NewPipe should be the same, and should hence be able to display all kinds of info items. E.g. info items that come to my mind are: video, channel, playlist, local playlist, video from history, subscription, ... So |
Yeah, definitely. I think it would be best to start with using a view model for the search fragment (I made a separate PR for that here: #8746) before switching to Paging there ( |
Isira-Seneviratne
force-pushed
the
Use_Paging
branch
from
ba477dc to
6ca604c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Isira-Seneviratne
force-pushed
the
Use_Paging
branch
from
6ca604c to
96649fb
Compare
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence